components/page_load_metrics/renderer/BUILD.gn - Issue 2100653002: PageLoadTiming fixes in prep for using base::Optional

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/page_load_metrics/renderer/BUILD.gn

Issue 2100653002: PageLoadTiming fixes in prep for using base::Optional (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: revert changes to PageLoadTiming Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/components_tests.gyp ('k') | components/page_load_metrics/renderer/fake_page_timing_metrics_ipc_sender.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/page_load_metrics/renderer/BUILD.gn

diff --git a/components/page_load_metrics/renderer/BUILD.gn b/components/page_load_metrics/renderer/BUILD.gn

index a427b350fcc4e0f338d8e28acd846df5eda0377c..0ebfda1fa9a87ff6a0a253d6238fb4a8f04d650b 100644

--- a/components/page_load_metrics/renderer/BUILD.gn

+++ b/components/page_load_metrics/renderer/BUILD.gn

@@ -25,6 +25,8 @@ static_library("renderer") {

source_set("unit_tests") {

testonly = true

sources = [

+ "fake_page_timing_metrics_ipc_sender.cc",

+ "fake_page_timing_metrics_ipc_sender.h",

"metrics_render_frame_observer_unittest.cc",

"page_timing_metrics_sender_unittest.cc",

]

« no previous file with comments | « components/components_tests.gyp ('k') | components/page_load_metrics/renderer/fake_page_timing_metrics_ipc_sender.h » ('j') | no next file with comments »