Run layout tests on Site Isolation Win FYI bot.

Run layout tests on Site Isolation Win FYI bot.

This CL modifies the bot's recipe to also run the full set of layout
tests with the --isolate-sites-for-testing=*.is flag.  This gives us
coverage for paths that are turned on by --isolate-extensions (we
can't use the actual --isolate-extensions flag, since content/ doesn't
know about it).  FlagExpectations/isolate-extensions will serve as the
disabled test list (similarly to site-per-process), and will be
uploaded in a separate CL.

BUG=477150, 532666
Committed: https://chromium.googlesource.com/chromium/tools/build/+/40627d4dfd79ca47a186cbd088e17c3f0691d0dc

[alexmos, 2016-06-24 22:58:03]

Description was changed from

==========
Run layout tests on Site Isolation Win FYI bot.

BUG=477150, 532666
==========

to

==========
Run layout tests on Site Isolation Win FYI bot.

This CL modifies the bot's recipe to also run the full set of layout
tests with the --isolate-extensions flag.
FlagExpectations/isolate-extensions will serve as the disabled test
list (similarly to site-per-process), and will be uploaded in a
separate CL.

BUG=477150, 532666
==========

[alexmos, 2016-06-24 23:12:44]

alexmos@chromium.org changed reviewers:
+ dpranke@chromium.org

[alexmos, 2016-06-24 23:12:45]

Dirk, can you please review?

We'd like to start running layout tests on our Site Isolation Win FYI bot, which
runs everything with --isolate-extensions.  This is basically just mirroring the
step for the Site Isolation Linux bot above (except that that bot uses
--site-per-process, and runs only the http/tests subset of tests).  I'll plan on
landing the exclusion list for the known failures in a separate CL
(https://codereview.chromium.org/2098073002) before landing this.

[Dirk Pranke, 2016-06-24 23:16:36]

lgtm

https://codereview.chromium.org/2100543002/diff/1/scripts/slave/recipe_module...
File scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py (right):

https://codereview.chromium.org/2100543002/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py:560:
'src\\third_party\\WebKit\\LayoutTests\\FlagExpectations\\isolate-extensions',
I'm not sure if backslashes or forward slashes matters much here ...

[alexmos, 2016-06-24 23:20:42]

Thanks!

https://codereview.chromium.org/2100543002/diff/1/scripts/slave/recipe_module...
File scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py (right):

https://codereview.chromium.org/2100543002/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py:560:
'src\\third_party\\WebKit\\LayoutTests\\FlagExpectations\\isolate-extensions',
On 2016/06/24 23:16:35, Dirk Pranke wrote:
> I'm not sure if backslashes or forward slashes matters much here ...

I wasn't sure either, but when I tried forward slashes, that preserved them into
the .json file, where all the other paths used backslashes.  That looked wrong,
so I changed it here.

[alexmos, 2016-06-24 23:30:41]

Also, thanks to Charlie, who pointed out that we should use a different flag
(--isolate-sites-for-testing=*.is instead of  --isolate-extensions), since
content/ doesn't know about extensions.  That flag turns on all the paths that
we actually want to test, and I've confirmed that the tests in the exclusion
list fail with it (but pass with --isolate-extensions).  I've switched to that
flag in PS2.

[alexmos, 2016-06-24 23:32:19]

Description was changed from

==========
Run layout tests on Site Isolation Win FYI bot.

This CL modifies the bot's recipe to also run the full set of layout
tests with the --isolate-extensions flag.
FlagExpectations/isolate-extensions will serve as the disabled test
list (similarly to site-per-process), and will be uploaded in a
separate CL.

BUG=477150, 532666
==========

to

==========
Run layout tests on Site Isolation Win FYI bot.

This CL modifies the bot's recipe to also run the full set of layout
tests with the --isolate-sites-for-testing=*.is flag.  This gives us
coverage for paths that are turned on by --isolate-extensions (we
can't use the actual --isolate-extensions flag, since content/ doesn't
know about it).  FlagExpectations/isolate-extensions will serve as the
disabled test list (similarly to site-per-process), and will be
uploaded in a separate CL.

BUG=477150, 532666
==========

[alexmos, 2016-06-27 22:08:17]

The CQ bit was checked by alexmos@chromium.org

[alexmos, 2016-06-27 22:08:17]

The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org
Link to the patchset: https://codereview.chromium.org/2100543002/#ps20001
(title: "Fix the flag (--isolate-extensions -> --isolate-sites-for-testing)")

[commit-bot: I haz the power, 2016-06-27 22:08:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[alexmos, 2016-06-27 22:08:25]

The CQ bit was unchecked by alexmos@chromium.org

[alexmos, 2016-06-27 22:09:18]

The CQ bit was checked by alexmos@chromium.org

[commit-bot: I haz the power, 2016-06-27 22:09:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-27 22:12:57]

Description was changed from

==========
Run layout tests on Site Isolation Win FYI bot.

This CL modifies the bot's recipe to also run the full set of layout
tests with the --isolate-sites-for-testing=*.is flag.  This gives us
coverage for paths that are turned on by --isolate-extensions (we
can't use the actual --isolate-extensions flag, since content/ doesn't
know about it).  FlagExpectations/isolate-extensions will serve as the
disabled test list (similarly to site-per-process), and will be
uploaded in a separate CL.

BUG=477150, 532666
==========

to

==========
Run layout tests on Site Isolation Win FYI bot.

This CL modifies the bot's recipe to also run the full set of layout
tests with the --isolate-sites-for-testing=*.is flag.  This gives us
coverage for paths that are turned on by --isolate-extensions (we
can't use the actual --isolate-extensions flag, since content/ doesn't
know about it).  FlagExpectations/isolate-extensions will serve as the
disabled test list (similarly to site-per-process), and will be
uploaded in a separate CL.

BUG=477150, 532666

Committed:
https://chromium.googlesource.com/chromium/tools/build/+/40627d4dfd79ca47a186...
==========

[commit-bot: I haz the power, 2016-06-27 22:12:58]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/tools/build/+/40627d4dfd79ca47a186...