Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issue 2100463002: Fix sizing of intrinsic size keywords in combination with box-sizing: border-box (Closed)

Created:
4 years, 6 months ago by cbiesinger
Modified:
4 years, 5 months ago
Reviewers:
dgrogan, eae
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix sizing of intrinsic size keywords in combination with box-sizing: border-box Keywords should not get adjusted by box-sizing: https://lists.w3.org/Archives/Public/www-style/2016Jun/0164.html But we had a bug in height computations as well as positioned width computations where we did adjust them. TEST=fast/css-intrinsic-dimensions/border-box-sizing.html BUG=549863, 522191 R=eae@chromium.org,dgrogan@chromium.org Committed: https://crrev.com/4820bd94507b69754af99a83b26a1cdcd936d134 Cr-Commit-Position: refs/heads/master@{#402210}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -9 lines) Patch
A third_party/WebKit/LayoutTests/fast/css-intrinsic-dimensions/border-box-sizing.html View 1 chunk +34 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBox.cpp View 7 chunks +22 lines, -9 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
cbiesinger
4 years, 6 months ago (2016-06-24 19:37:25 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2100463002/1
4 years, 6 months ago (2016-06-24 19:37:54 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-24 20:54:44 UTC) #5
eae
Nice, LGTM
4 years, 5 months ago (2016-06-27 16:04:58 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2100463002/1
4 years, 5 months ago (2016-06-27 16:05:53 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-27 17:21:23 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-06-27 17:23:14 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4820bd94507b69754af99a83b26a1cdcd936d134
Cr-Commit-Position: refs/heads/master@{#402210}

Powered by Google App Engine
This is Rietveld 408576698