Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 21004010: Compile v8 like "release" by default in debug builds. (Closed)

Created:
7 years, 4 months ago by Dirk Pranke
Modified:
7 years, 4 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Compile v8 like "release" by default in debug builds. This change switches how we compile v8 by default in Debug builds so that the compiler optimizations are enabled and much of the still enabled to do some level of dcheck-like assertion checking). This gives us a 5x speedup over the debug v8 for running the layout tests, making debug times only 2x slower than release. R=jamesr@chromium.org, jochen@chromium.org BUG=254188 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=216287

Patch Set 1 #

Patch Set 2 : use v8_optimized_debug=1 on android_clang #

Patch Set 3 : use v8_optimized_debug on all android #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -4 lines) Patch
M build/common.gypi View 1 2 3 chunks +11 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Dirk Pranke
7 years, 4 months ago (2013-07-30 20:09:57 UTC) #1
jochen (gone - plz use gerrit)
lgtm
7 years, 4 months ago (2013-07-30 20:12:16 UTC) #2
jamesr
lgtm2
7 years, 4 months ago (2013-07-30 20:23:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dpranke@chromium.org/21004010/1
7 years, 4 months ago (2013-07-30 21:06:48 UTC) #4
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 4 months ago (2013-07-30 22:34:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dpranke@chromium.org/21004010/23001
7 years, 4 months ago (2013-07-31 01:09:27 UTC) #6
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 4 months ago (2013-07-31 01:58:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dpranke@chromium.org/21004010/36001
7 years, 4 months ago (2013-07-31 03:19:04 UTC) #8
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 4 months ago (2013-07-31 04:02:29 UTC) #9
Dirk Pranke
7 years, 4 months ago (2013-08-07 22:09:10 UTC) #10
Message was sent while issue was closed.
Committed patchset #3 manually as r216287 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698