Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1210)

Unified Diff: build/common.gypi

Issue 21004010: Compile v8 like "release" by default in debug builds. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: use v8_optimized_debug on all android Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index d67c5f1c0161218552903a322c0a7fede2474683..7ba1ac89be02101045f25d52e06f0f0b53c56b4a 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -689,7 +689,16 @@
}],
['OS=="win" or OS=="linux"', {
'enable_mdns%' : 1,
- }]
+ }],
+
+ # Turns on compiler optimizations in V8 in Debug build, except
+ # on android_clang, where we're hitting a weird linker error.
+ # TODO(dpranke): http://crbug.com/266155 .
+ ['OS=="android"', {
+ 'v8_optimized_debug': 1,
+ }, {
+ 'v8_optimized_debug': 2,
+ }],
],
# Set this to 1 to enable use of concatenated impulse responses
@@ -842,6 +851,7 @@
'spdy_proxy_auth_property%': '<(spdy_proxy_auth_property)',
'spdy_proxy_auth_value%': '<(spdy_proxy_auth_value)',
'enable_mdns%' : '<(enable_mdns)',
+ 'v8_optimized_debug': '<(v8_optimized_debug)',
# Use system mesa instead of bundled one.
'use_system_mesa%': 0,
@@ -1102,9 +1112,6 @@
# rlz codes for searches but do not use the library.
'enable_rlz%': 0,
- # Turns on compiler optimizations in V8 in Debug build.
- 'v8_optimized_debug': 1,
-
# Turns on the i18n support in V8.
'v8_enable_i18n_support': 1,
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698