Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(364)

Issue 21003: Review request: fix issue 7253 - tooltip of Pure English tab title has wrong directionality (Closed)

Created:
11 years, 10 months ago by xji
Modified:
9 years, 6 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

This CL fix issue 7253 -- tooltip of pure English tab title has wrong directionality. (http://crbug.com/7253) Fix: LTR tooltip text need to be marked with LRE-PDF to be displayed correctly in RTL locales. Test steps: 1. Open Chrome in RTL locales. 2. Open page http://mail.yahoo.com, whose title is "Yahoo! Mail: the best web-based mail!" 3. Mouse over to the tab title to show the completed page title. Without the fix, tooltip text is: "!Yahoo! Mail: the best web-based mail" (with wrong placement of the ending punctuation). With the fix, tooltip text is: "Yahoo! Mail: the best web-based mail!" Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=9064

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M chrome/views/tooltip_manager.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
xji
11 years, 10 months ago (2009-02-03 01:43:40 UTC) #1
idana
LGTM
11 years, 10 months ago (2009-02-03 01:46:11 UTC) #2
jeremy
11 years, 10 months ago (2009-02-03 03:25:04 UTC) #3
lgtm

Powered by Google App Engine
This is Rietveld 408576698