Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 2100233002: Also use EXPECT_NEAR in AllFramesGetDefaultZoom and SubframeRetainsZoomOnNavigation. (Closed)

Created:
4 years, 5 months ago by ghost stip (do not use)
Modified:
4 years, 5 months ago
Reviewers:
wjmaclean, Charlie Reis
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Also use EXPECT_NEAR in AllFramesGetDefaultZoom and SubframeRetainsZoomOnNavigation. BUG=622858 Committed: https://crrev.com/838630d2efaf6ad90ab5b3c18bd752ac9d4fd144 Cr-Commit-Position: refs/heads/master@{#402358}

Patch Set 1 #

Total comments: 3

Patch Set 2 : Change SubframeRetainsZoomOnNavigation as well. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -4 lines) Patch
M content/browser/iframe_zoom_browsertest.cc View 1 2 chunks +12 lines, -4 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
ghost stip (do not use)
ptal! This fixes up one test which got missed in https://codereview.chromium.org/2097063002.
4 years, 5 months ago (2016-06-27 21:05:41 UTC) #3
wjmaclean
On 2016/06/27 21:05:41, stip wrote: > ptal! > > This fixes up one test which ...
4 years, 5 months ago (2016-06-27 21:15:21 UTC) #4
Charlie Reis
If we're trying to avoid future flakiness, it looks like there might be one more ...
4 years, 5 months ago (2016-06-27 21:23:08 UTC) #5
wjmaclean
https://codereview.chromium.org/2100233002/diff/1/content/browser/iframe_zoom_browsertest.cc File content/browser/iframe_zoom_browsertest.cc (right): https://codereview.chromium.org/2100233002/diff/1/content/browser/iframe_zoom_browsertest.cc#newcode422 content/browser/iframe_zoom_browsertest.cc:422: EXPECT_DOUBLE_EQ( On 2016/06/27 21:23:08, Charlie Reis wrote: > What ...
4 years, 5 months ago (2016-06-27 21:53:58 UTC) #6
ghost stip (do not use)
AllFramesGetDefaultZoom is still failing on https://build.chromium.org/p/chromium.android/builders/Android%20N5X%20Swarm%20Builder: https://build.chromium.org/p/chromium.android/builders/Android%20N5X%20Swarm%20Builder/builds/1406/steps/content_browsertests%20on%20Android (I used the android_n5x_swarming_rel bot to check). Either ...
4 years, 5 months ago (2016-06-27 23:21:16 UTC) #8
wjmaclean
On 2016/06/27 23:21:16, stip wrote: > AllFramesGetDefaultZoom is still failing on > https://build.chromium.org/p/chromium.android/builders/Android%20N5X%20Swarm%20Builder: > https://build.chromium.org/p/chromium.android/builders/Android%20N5X%20Swarm%20Builder/builds/1406/steps/content_browsertests%20on%20Android ...
4 years, 5 months ago (2016-06-27 23:24:35 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2100233002/20001
4 years, 5 months ago (2016-06-27 23:43:40 UTC) #11
Charlie Reis
LGTM
4 years, 5 months ago (2016-06-27 23:45:27 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-06-28 01:09:19 UTC) #14
commit-bot: I haz the power
4 years, 5 months ago (2016-06-28 01:12:05 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/838630d2efaf6ad90ab5b3c18bd752ac9d4fd144
Cr-Commit-Position: refs/heads/master@{#402358}

Powered by Google App Engine
This is Rietveld 408576698