Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 2097063002: Use approximate zoom level comparisons in test to accommodate N5X. (Closed)

Created:
4 years, 6 months ago by wjmaclean
Modified:
4 years, 5 months ago
Reviewers:
Charlie Reis
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use approximate zoom level comparisons in test to accommodate N5X. Zoom level comparisons in test on the N5X bots are returning results that are off by a fraction of a percent, but otherwise seem fine. This CL changes EXPECT_DOUBLE_EQ to EXPECT_NEAR to accommodate this. BUG=622858 TBR=creis@chromium.org Committed: https://crrev.com/4b90fc62dee86ae8a3426df7e45f4253c79ed77a Cr-Commit-Position: refs/heads/master@{#401859}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -4 lines) Patch
M content/browser/iframe_zoom_browsertest.cc View 2 chunks +10 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2097063002/1
4 years, 6 months ago (2016-06-24 12:19:50 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-24 13:06:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2097063002/1
4 years, 6 months ago (2016-06-24 13:52:48 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-24 13:55:48 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/4b90fc62dee86ae8a3426df7e45f4253c79ed77a Cr-Commit-Position: refs/heads/master@{#401859}
4 years, 6 months ago (2016-06-24 13:57:58 UTC) #9
Charlie Reis
It looks like you sent this to the CQ without ever emailing reviewers. Please remember ...
4 years, 5 months ago (2016-06-27 21:22:33 UTC) #10
wjmaclean
4 years, 5 months ago (2016-06-27 21:35:37 UTC) #11
Message was sent while issue was closed.
On 2016/06/27 21:22:33, Charlie Reis wrote:
> It looks like you sent this to the CQ without ever emailing reviewers.  Please
> remember to publish a message to reviewers when you TBR them, or they won't
know
> to look at it.  :)
> 
> LGTM.

Ooops, sorry ... I thought the TBR did that automatically (I really try to avoid
using it ...)

Powered by Google App Engine
This is Rietveld 408576698