Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1797)

Unified Diff: net/tools/quic/quic_simple_server_stream.cc

Issue 2100213002: Make QuicSpdyStream::ParseHeaderStatusCode() inparam const. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/quic_spdy_stream_test.cc ('k') | net/tools/quic/quic_spdy_client_stream.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/tools/quic/quic_simple_server_stream.cc
diff --git a/net/tools/quic/quic_simple_server_stream.cc b/net/tools/quic/quic_simple_server_stream.cc
index 21a7a8fd2adddda326d9e036a2e0f9cddf271dff..96b733cebd7f6c13f4b2b8ec98415fc2636dd453 100644
--- a/net/tools/quic/quic_simple_server_stream.cc
+++ b/net/tools/quic/quic_simple_server_stream.cc
@@ -168,11 +168,11 @@ void QuicSimpleServerStream::SendResponse() {
string request_url = request_headers_[":authority"].as_string() +
request_headers_[":path"].as_string();
int response_code;
- SpdyHeaderBlock response_headers = response->headers();
- if (!ParseHeaderStatusCode(&response_headers, &response_code)) {
- DVLOG(1) << "Illegal (non-integer) response :status from cache: "
- << response_headers[":status"].as_string() << " for request "
- << request_url;
+ const SpdyHeaderBlock& response_headers = response->headers();
+ if (!ParseHeaderStatusCode(response_headers, &response_code)) {
+ LOG(WARNING) << "Illegal (non-integer) response :status from cache: "
+ << response_headers.GetHeader(":status") << " for request "
+ << request_url;
SendErrorResponse();
return;
}
« no previous file with comments | « net/quic/quic_spdy_stream_test.cc ('k') | net/tools/quic/quic_spdy_client_stream.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698