Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(445)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: net/quic/quic_spdy_stream_test.cc

Issue 2100213002: Make QuicSpdyStream::ParseHeaderStatusCode() inparam const. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/quic_spdy_stream.cc ('k') | net/tools/quic/quic_simple_server_stream.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_spdy_stream_test.cc
diff --git a/net/quic/quic_spdy_stream_test.cc b/net/quic/quic_spdy_stream_test.cc
index 7a1b8540f92a1628f93fe68c4afbbe259aa74a63..47b56cead4dea414f86ed2f90c75a9067d788c88 100644
--- a/net/quic/quic_spdy_stream_test.cc
+++ b/net/quic/quic_spdy_stream_test.cc
@@ -198,40 +198,40 @@ TEST_P(QuicSpdyStreamTest, ParseHeaderStatusCode) {
// Valid status code.
headers_.ReplaceOrAppendHeader(":status", "404");
- EXPECT_TRUE(stream_->ParseHeaderStatusCode(&headers_, &status_code));
+ EXPECT_TRUE(stream_->ParseHeaderStatusCode(headers_, &status_code));
EXPECT_EQ(404, status_code);
// Invalid status codes.
headers_.ReplaceOrAppendHeader(":status", "010");
- EXPECT_FALSE(stream_->ParseHeaderStatusCode(&headers_, &status_code));
+ EXPECT_FALSE(stream_->ParseHeaderStatusCode(headers_, &status_code));
headers_.ReplaceOrAppendHeader(":status", "600");
- EXPECT_FALSE(stream_->ParseHeaderStatusCode(&headers_, &status_code));
+ EXPECT_FALSE(stream_->ParseHeaderStatusCode(headers_, &status_code));
headers_.ReplaceOrAppendHeader(":status", "200 ok");
- EXPECT_FALSE(stream_->ParseHeaderStatusCode(&headers_, &status_code));
+ EXPECT_FALSE(stream_->ParseHeaderStatusCode(headers_, &status_code));
headers_.ReplaceOrAppendHeader(":status", "2000");
- EXPECT_FALSE(stream_->ParseHeaderStatusCode(&headers_, &status_code));
+ EXPECT_FALSE(stream_->ParseHeaderStatusCode(headers_, &status_code));
headers_.ReplaceOrAppendHeader(":status", "+200");
- EXPECT_FALSE(stream_->ParseHeaderStatusCode(&headers_, &status_code));
+ EXPECT_FALSE(stream_->ParseHeaderStatusCode(headers_, &status_code));
headers_.ReplaceOrAppendHeader(":status", "+20");
- EXPECT_FALSE(stream_->ParseHeaderStatusCode(&headers_, &status_code));
+ EXPECT_FALSE(stream_->ParseHeaderStatusCode(headers_, &status_code));
// Leading or trailing spaces are also invalid.
headers_.ReplaceOrAppendHeader(":status", " 200");
- EXPECT_FALSE(stream_->ParseHeaderStatusCode(&headers_, &status_code));
+ EXPECT_FALSE(stream_->ParseHeaderStatusCode(headers_, &status_code));
headers_.ReplaceOrAppendHeader(":status", "200 ");
- EXPECT_FALSE(stream_->ParseHeaderStatusCode(&headers_, &status_code));
+ EXPECT_FALSE(stream_->ParseHeaderStatusCode(headers_, &status_code));
headers_.ReplaceOrAppendHeader(":status", " 200 ");
- EXPECT_FALSE(stream_->ParseHeaderStatusCode(&headers_, &status_code));
+ EXPECT_FALSE(stream_->ParseHeaderStatusCode(headers_, &status_code));
headers_.ReplaceOrAppendHeader(":status", " ");
- EXPECT_FALSE(stream_->ParseHeaderStatusCode(&headers_, &status_code));
+ EXPECT_FALSE(stream_->ParseHeaderStatusCode(headers_, &status_code));
}
TEST_P(QuicSpdyStreamTest, MarkHeadersConsumed) {
« no previous file with comments | « net/quic/quic_spdy_stream.cc ('k') | net/tools/quic/quic_simple_server_stream.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698