Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(457)

Issue 2100203002: Revert of Turn on enable begin frame scheduling by default (Closed)

Created:
4 years, 5 months ago by enne (OOO)
Modified:
4 years, 5 months ago
Reviewers:
sunnyps, piman, Sami, boliu
CC:
achuith+watch_chromium.org, android-webview-reviews_chromium.org, cc-bugs_chromium.org, chromium-reviews, creis+watch_chromium.org, danakj+watch_chromium.org, darin-cc_chromium.org, davemoore+watch_chromium.org, dzhioev+watch_chromium.org, jam, jbauman+watch_chromium.org, kalyank, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org, nona+watch_chromium.org, oshima+watch_chromium.org, piman+watch_chromium.org, shuchen+watch_chromium.org, sievers+watch_chromium.org, James Su, tdresser, Ian Vollick, yusukes+watch_chromium.org, brianderson
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Turn on enable begin frame scheduling by default (patchset #11 id:200001 of https://codereview.chromium.org/1939253002/ ) Reason for revert: Causes smoothness regressions, other bugs BUG=623174, 623467, 623490 Original issue's description: > Turn on enable begin frame scheduling by default > > This turns on --enable-begin-frame-scheduling[1] for all[2] platforms. > This was already on for Android so should only be a real change > for desktop / ChromeOS platforms. > > Lots of cleanup can follow from this like removing all commit vsync / > authoritative vsync / CompositorVSyncManager things, but this is a > smaller patch to suss out any performance regressions. > > [1] In this case, "begin frame scheduling" means browser->renderer > begin frame ticks instead of sending vsync information and having > a synthetic source on the renderer side. > > [2] MUS is not hooked up to begin frame scheduling yet, but > mojo:mash_session in an "oxygen" build still works with this patch > applied. Blimp also doesn't use begin frame scheduling and will > eventually just be transitioned to a synthetic begin frame source > for its engine half. > > CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel > > Committed: https://crrev.com/f2d7f5e1891703ec4384ededd80f896816921204 > Cr-Commit-Position: refs/heads/master@{#401796} TBR=boliu@chromium.org,piman@chromium.org,skyostil@chromium.org,sunnyps@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. Committed: https://crrev.com/7ea3a9cd847d7478598d22804d04c32c156c14f4 Cr-Commit-Position: refs/heads/master@{#402294}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -12 lines) Patch
M android_webview/lib/main/aw_main_delegate.cc View 1 chunk +1 line, -0 lines 0 comments Download
M cc/base/switches.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/base/switches.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/chrome_restart_request.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/android/content_startup_flags.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/compositor/browser_compositor_output_surface.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/gpu/render_widget_compositor.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/compositor/compositor.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
enne (OOO)
Created Revert of Turn on enable begin frame scheduling by default
4 years, 5 months ago (2016-06-27 18:23:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2100203002/1
4 years, 5 months ago (2016-06-27 18:24:17 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/192314)
4 years, 5 months ago (2016-06-27 19:17:35 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2100203002/1
4 years, 5 months ago (2016-06-27 19:47:08 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-27 21:38:58 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-06-27 21:40:45 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7ea3a9cd847d7478598d22804d04c32c156c14f4
Cr-Commit-Position: refs/heads/master@{#402294}

Powered by Google App Engine
This is Rietveld 408576698