Options: more tweaks to android-settings strings.

Options: more tweaks to android-settings strings.

Fix some capitalization issues.
Reword the "Remove android apps?" dialog to spec.

R=dbeam@chromium.org
BUG=623232
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/a446df3b0e1e39f390400729db2f49d1437ee9e8
Cr-Commit-Position: refs/heads/master@{#402308}

[Dan Beam, 2016-06-27 17:40:38]

https://codereview.chromium.org/2100143002/diff/20001/chrome/app/chromeos_str...
File chrome/app/chromeos_strings.grdp (right):

https://codereview.chromium.org/2100143002/diff/20001/chrome/app/chromeos_str...
chrome/app/chromeos_strings.grdp:6693: <ph name="MARKUP_1">&lt;p&gt;</ph>Apps
you’ve downloaded from Google Play will be deleted from this Chromebook.<ph
name="MARKUP_2">&lt;/p&gt;</ph>
you don't need <ph> (placeholders) if you're not doing substitutions

also, I think this can just be:
"""

Apps you’ve downloaded from Google Play will be deleted from this Chromebook.

Content you’ve purchased such as movies, TV shows, music, books, or other in-app
purchases may also be deleted.

This doesn’t affect apps or content on other devices.

"""
if you use it in conjunction with white-space: pre-line;
https://jsfiddle.net/nrxuh1pu/

https://codereview.chromium.org/2100143002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/options/browser_options.css (right):

https://codereview.chromium.org/2100143002/diff/20001/chrome/browser/resource...
chrome/browser/resources/options/browser_options.css:6: margin-left: 30px;
feel free to change this to -webkit-margin-start: 30px; if you'd like (or I can
separately)

just verified locally that this does the wrong thing in RTL :(

https://codereview.chromium.org/2100143002/diff/20001/chrome/browser/resource...
chrome/browser/resources/options/browser_options.css:491: margin-left: 30px;
you copied a naughty example (sorry!); this doesn't work in RTL.

use -webkit-margin-start: 30px; instead

[Ben Kwa, 2016-06-27 17:52:15]

Done, PTAL.

thanks!

https://codereview.chromium.org/2100143002/diff/20001/chrome/app/chromeos_str...
File chrome/app/chromeos_strings.grdp (right):

https://codereview.chromium.org/2100143002/diff/20001/chrome/app/chromeos_str...
chrome/app/chromeos_strings.grdp:6693: <ph name="MARKUP_1">&lt;p&gt;</ph>Apps
you’ve downloaded from Google Play will be deleted from this Chromebook.<ph
name="MARKUP_2">&lt;/p&gt;</ph>
On 2016/06/27 17:40:38, Dan Beam wrote:
> you don't need <ph> (placeholders) if you're not doing substitutions
> 
> also, I think this can just be:
> """
> 
> Apps you’ve downloaded from Google Play will be deleted from this Chromebook.
> 
> Content you’ve purchased such as movies, TV shows, music, books, or other
in-app
> purchases may also be deleted.
> 
> This doesn’t affect apps or content on other devices.
> 
> """
> if you use it in conjunction with white-space: pre-line;
> https://jsfiddle.net/nrxuh1pu/

Much cleaner, thanks!

https://codereview.chromium.org/2100143002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/options/browser_options.css (right):

https://codereview.chromium.org/2100143002/diff/20001/chrome/browser/resource...
chrome/browser/resources/options/browser_options.css:6: margin-left: 30px;
On 2016/06/27 17:40:38, Dan Beam wrote:
> feel free to change this to -webkit-margin-start: 30px; if you'd like (or I
can
> separately)
> 
> just verified locally that this does the wrong thing in RTL :(

Done.

https://codereview.chromium.org/2100143002/diff/20001/chrome/browser/resource...
chrome/browser/resources/options/browser_options.css:491: margin-left: 30px;
On 2016/06/27 17:40:38, Dan Beam wrote:
> you copied a naughty example (sorry!); this doesn't work in RTL.
> 
> use -webkit-margin-start: 30px; instead

Done.  Thanks for the catch.

[Dan Beam, 2016-06-27 18:10:48]

https://codereview.chromium.org/2100143002/diff/60001/chrome/app/chromeos_str...
File chrome/app/chromeos_strings.grdp (right):

https://codereview.chromium.org/2100143002/diff/60001/chrome/app/chromeos_str...
chrome/app/chromeos_strings.grdp:6692: <message
name="IDS_ARC_OPT_OUT_DIALOG_DESCRIPTION" desc="Describes what will happen if
the user opts out of android apps">
you might want to mention that newlines are preserved for translators

https://codereview.chromium.org/2100143002/diff/60001/chrome/browser/resource...
File chrome/browser/resources/options/chromeos/arc_opt_out_confirm_overlay.css
(right):

https://codereview.chromium.org/2100143002/diff/60001/chrome/browser/resource...
chrome/browser/resources/options/chromeos/arc_opt_out_confirm_overlay.css:9:
.content-area {
you need to scope this to

  #arc-opt-out-confirm-overlay .content-area {
    white-space: pre-line;
  }

otherwise all dialogs might be affected

[Ben Kwa, 2016-06-27 18:44:08]

https://codereview.chromium.org/2100143002/diff/60001/chrome/app/chromeos_str...
File chrome/app/chromeos_strings.grdp (right):

https://codereview.chromium.org/2100143002/diff/60001/chrome/app/chromeos_str...
chrome/app/chromeos_strings.grdp:6692: <message
name="IDS_ARC_OPT_OUT_DIALOG_DESCRIPTION" desc="Describes what will happen if
the user opts out of android apps">
On 2016/06/27 18:10:48, Dan Beam wrote:
> you might want to mention that newlines are preserved for translators

Done.

https://codereview.chromium.org/2100143002/diff/60001/chrome/browser/resource...
File chrome/browser/resources/options/chromeos/arc_opt_out_confirm_overlay.css
(right):

https://codereview.chromium.org/2100143002/diff/60001/chrome/browser/resource...
chrome/browser/resources/options/chromeos/arc_opt_out_confirm_overlay.css:9:
.content-area {
On 2016/06/27 18:10:48, Dan Beam wrote:
> you need to scope this to
> 
>   #arc-opt-out-confirm-overlay .content-area {
>     white-space: pre-line;
>   }
> 
> otherwise all dialogs might be affected

Done.

[Dan Beam, 2016-06-27 19:29:12]

lgtm

[Ben Kwa, 2016-06-27 20:31:53]

The CQ bit was checked by kenobi@chromium.org

[commit-bot: I haz the power, 2016-06-27 20:33:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-27 22:00:42]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-06-27 22:03:20]

Description was changed from

==========
Options: more tweaks to android-settings strings.

Fix some capitalization issues.
Reword the "Remove android apps?" dialog to spec.

R=dbeam@chromium.org
BUG=623232
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
Options: more tweaks to android-settings strings.

Fix some capitalization issues.
Reword the "Remove android apps?" dialog to spec.

R=dbeam@chromium.org
BUG=623232
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/a446df3b0e1e39f390400729db2f49d1437ee9e8
Cr-Commit-Position: refs/heads/master@{#402308}
==========

[commit-bot: I haz the power, 2016-06-27 22:03:21]

Patchset 5 (id:??) landed as
https://crrev.com/a446df3b0e1e39f390400729db2f49d1437ee9e8
Cr-Commit-Position: refs/heads/master@{#402308}