Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issue 2100063002: [turbofan] Fold word32 representation changes for checked constants. (Closed)

Created:
4 years, 5 months ago by Benedikt Meurer
Modified:
4 years, 5 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Fold word32 representation changes for checked constants. If we know that a constant can be represented as word32, then we don't need to insert a checked conversion, but just change the constant appropriately. R=jarin@chromium.org Committed: https://crrev.com/bd8a36a7275161cc25e16b4be67c5fe578e49e7e Cr-Commit-Position: refs/heads/master@{#37273}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -12 lines) Patch
M src/compiler/representation-change.cc View 1 chunk +23 lines, -12 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Benedikt Meurer
4 years, 5 months ago (2016-06-27 07:20:03 UTC) #1
Benedikt Meurer
Hey Jaro, Here's the fix for the issue you discovered. Please take a look. Thanks, ...
4 years, 5 months ago (2016-06-27 07:20:48 UTC) #2
Jarin
lgtm. Thanks.
4 years, 5 months ago (2016-06-27 07:22:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2100063002/1
4 years, 5 months ago (2016-06-27 07:24:15 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-27 07:43:53 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-06-27 07:46:30 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bd8a36a7275161cc25e16b4be67c5fe578e49e7e
Cr-Commit-Position: refs/heads/master@{#37273}

Powered by Google App Engine
This is Rietveld 408576698