Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 2099823002: mac: Don't build bits of GTM we don't use. (Closed)

Created:
4 years, 6 months ago by Nico
Modified:
4 years, 6 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mac: Don't build bits of GTM we don't use. Some of GTM is pretty old and fires deprecation warnings with a 10.8 deployment target. Remove parts of GTM we don't use from the build, to get fewer of those. No intended behavior change. BUG=622481 Committed: https://crrev.com/c23cd73367a4e1ba3b2ffb521ffd92afc98acad1 Cr-Commit-Position: refs/heads/master@{#401976}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -202 lines) Patch
M third_party/google_toolbox_for_mac/BUILD.gn View 2 chunks +2 lines, -101 lines 0 comments Download
M third_party/google_toolbox_for_mac/google_toolbox_for_mac.gyp View 1 chunk +0 lines, -101 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Nico
4 years, 6 months ago (2016-06-24 20:15:05 UTC) #3
Robert Sesek
LGTM. I wonder why we included all that in the build to begin with. Why ...
4 years, 6 months ago (2016-06-24 20:53:06 UTC) #4
Nico
in gyp (and I think as of last week in gn too), a component is ...
4 years, 6 months ago (2016-06-24 20:55:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2099823002/1
4 years, 6 months ago (2016-06-24 20:55:49 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-24 21:28:21 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-06-24 21:30:32 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c23cd73367a4e1ba3b2ffb521ffd92afc98acad1
Cr-Commit-Position: refs/heads/master@{#401976}

Powered by Google App Engine
This is Rietveld 408576698