Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: third_party/google_toolbox_for_mac/BUILD.gn

Issue 2099823002: mac: Don't build bits of GTM we don't use. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/google_toolbox_for_mac/google_toolbox_for_mac.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/google_toolbox_for_mac/BUILD.gn
diff --git a/third_party/google_toolbox_for_mac/BUILD.gn b/third_party/google_toolbox_for_mac/BUILD.gn
index fccd6b6c188ee298e44c632ac311aa72f5e2a7a5..f94c6e5f9148afeb930a728525ef1ee849f70793 100644
--- a/third_party/google_toolbox_for_mac/BUILD.gn
+++ b/third_party/google_toolbox_for_mac/BUILD.gn
@@ -14,6 +14,8 @@ config("google_toolbox_for_mac_public_config") {
component("google_toolbox_for_mac") {
sources = [
+ # TODO(thakis): On Mac, we only use GTMStringEncoding. Check which are used
+ # on iOS and remove the unused ones.
"src/DebugUtils/GTMMethodCheck.h",
"src/DebugUtils/GTMMethodCheck.m",
"src/Foundation/GTMLightweightProxy.h",
@@ -40,129 +42,28 @@ component("google_toolbox_for_mac") {
if (!is_ios) {
sources += [
- "src/AddressBook/GTMABAddressBook.h",
- "src/AddressBook/GTMABAddressBook.m",
"src/AppKit/GTMCarbonEvent.h",
"src/AppKit/GTMCarbonEvent.m",
- "src/AppKit/GTMDelegatingTableColumn.h",
- "src/AppKit/GTMDelegatingTableColumn.m",
"src/AppKit/GTMFadeTruncatingTextFieldCell.h",
"src/AppKit/GTMFadeTruncatingTextFieldCell.m",
- "src/AppKit/GTMGetURLHandler.m",
- "src/AppKit/GTMGoogleSearch.h",
- "src/AppKit/GTMGoogleSearch.m",
- "src/AppKit/GTMHotKeyTextField.h",
- "src/AppKit/GTMHotKeyTextField.m",
- "src/AppKit/GTMIBArray.h",
- "src/AppKit/GTMIBArray.m",
"src/AppKit/GTMKeyValueAnimation.h",
"src/AppKit/GTMKeyValueAnimation.m",
- "src/AppKit/GTMLargeTypeWindow.h",
- "src/AppKit/GTMLargeTypeWindow.m",
- "src/AppKit/GTMLinearRGBShading.h",
- "src/AppKit/GTMLinearRGBShading.m",
- "src/AppKit/GTMLoginItems.h",
- "src/AppKit/GTMLoginItems.m",
- "src/AppKit/GTMNSAnimatablePropertyContainer.h",
- "src/AppKit/GTMNSAnimatablePropertyContainer.m",
"src/AppKit/GTMNSAnimation+Duration.h",
"src/AppKit/GTMNSAnimation+Duration.m",
"src/AppKit/GTMNSBezierPath+CGPath.h",
"src/AppKit/GTMNSBezierPath+CGPath.m",
"src/AppKit/GTMNSBezierPath+RoundRect.h",
"src/AppKit/GTMNSBezierPath+RoundRect.m",
- "src/AppKit/GTMNSBezierPath+Shading.h",
- "src/AppKit/GTMNSBezierPath+Shading.m",
"src/AppKit/GTMNSColor+Luminance.h",
"src/AppKit/GTMNSColor+Luminance.m",
- "src/AppKit/GTMNSImage+Scaling.h",
- "src/AppKit/GTMNSImage+Scaling.m",
- "src/AppKit/GTMNSImage+SearchCache.h",
- "src/AppKit/GTMNSImage+SearchCache.m",
- "src/AppKit/GTMNSWorkspace+Running.h",
- "src/AppKit/GTMNSWorkspace+Running.m",
- "src/AppKit/GTMShading.h",
"src/AppKit/GTMUILocalizer.h",
"src/AppKit/GTMUILocalizer.m",
"src/AppKit/GTMUILocalizerAndLayoutTweaker.h",
"src/AppKit/GTMUILocalizerAndLayoutTweaker.m",
"src/DebugUtils/GTMDebugSelectorValidation.h",
- "src/DebugUtils/GTMDebugThreadValidation.h",
- "src/DebugUtils/GTMDebugThreadValidation.m",
"src/DebugUtils/GTMTypeCasting.h",
- "src/Foundation/GTMAbstractDOListener.h",
- "src/Foundation/GTMAbstractDOListener.m",
- "src/Foundation/GTMCalculatedRange.h",
- "src/Foundation/GTMCalculatedRange.m",
- "src/Foundation/GTMExceptionalInlines.h",
- "src/Foundation/GTMExceptionalInlines.m",
- "src/Foundation/GTMFileSystemKQueue.h",
- "src/Foundation/GTMFileSystemKQueue.m",
- "src/Foundation/GTMFourCharCode.h",
- "src/Foundation/GTMFourCharCode.m",
- "src/Foundation/GTMGarbageCollection.h",
- "src/Foundation/GTMGeometryUtils.h",
- "src/Foundation/GTMGeometryUtils.m",
- "src/Foundation/GTMLocalizedString.h",
- "src/Foundation/GTMLogger+ASL.h",
- "src/Foundation/GTMLogger+ASL.m",
- "src/Foundation/GTMLoggerRingBufferWriter.h",
- "src/Foundation/GTMLoggerRingBufferWriter.m",
- "src/Foundation/GTMNSAppleEventDescriptor+Foundation.h",
- "src/Foundation/GTMNSAppleEventDescriptor+Foundation.m",
- "src/Foundation/GTMNSAppleEventDescriptor+Handler.h",
- "src/Foundation/GTMNSAppleEventDescriptor+Handler.m",
- "src/Foundation/GTMNSAppleScript+Handler.h",
- "src/Foundation/GTMNSAppleScript+Handler.m",
- "src/Foundation/GTMNSArray+Merge.h",
- "src/Foundation/GTMNSArray+Merge.m",
- "src/Foundation/GTMNSDictionary+CaseInsensitive.h",
- "src/Foundation/GTMNSDictionary+CaseInsensitive.m",
- "src/Foundation/GTMNSEnumerator+Filter.h",
- "src/Foundation/GTMNSEnumerator+Filter.m",
- "src/Foundation/GTMNSFileHandle+UniqueName.h",
- "src/Foundation/GTMNSFileHandle+UniqueName.m",
- "src/Foundation/GTMNSFileManager+Carbon.h",
- "src/Foundation/GTMNSFileManager+Carbon.m",
- "src/Foundation/GTMNSFileManager+Path.h",
- "src/Foundation/GTMNSFileManager+Path.m",
- "src/Foundation/GTMNSNumber+64Bit.h",
- "src/Foundation/GTMNSNumber+64Bit.m",
- "src/Foundation/GTMNSScanner+JSON.h",
- "src/Foundation/GTMNSScanner+JSON.m",
- "src/Foundation/GTMNSScanner+Unsigned.h",
- "src/Foundation/GTMNSScanner+Unsigned.m",
- "src/Foundation/GTMNSString+FindFolder.h",
- "src/Foundation/GTMNSString+FindFolder.m",
- "src/Foundation/GTMNSString+Replace.h",
- "src/Foundation/GTMNSString+Replace.m",
- "src/Foundation/GTMNSString+XML.h",
- "src/Foundation/GTMNSString+XML.m",
- "src/Foundation/GTMNSThread+Blocks.h",
- "src/Foundation/GTMNSThread+Blocks.m",
- "src/Foundation/GTMObjC2Runtime.h",
- "src/Foundation/GTMObjC2Runtime.m",
- "src/Foundation/GTMObjectSingleton.h",
- "src/Foundation/GTMPath.h",
- "src/Foundation/GTMPath.m",
- "src/Foundation/GTMScriptRunner.h",
- "src/Foundation/GTMScriptRunner.m",
"src/Foundation/GTMServiceManagement.c",
"src/Foundation/GTMServiceManagement.h",
- "src/Foundation/GTMSignalHandler.h",
- "src/Foundation/GTMSignalHandler.m",
- "src/Foundation/GTMStackTrace.h",
- "src/Foundation/GTMStackTrace.m",
- "src/Foundation/GTMSystemVersion.h",
- "src/Foundation/GTMSystemVersion.m",
- "src/Foundation/GTMTransientRootPortProxy.h",
- "src/Foundation/GTMTransientRootPortProxy.m",
- "src/Foundation/GTMTransientRootProxy.h",
- "src/Foundation/GTMTransientRootProxy.m",
- "src/Foundation/GTMURITemplate.h",
- "src/Foundation/GTMURITemplate.m",
- "src/Foundation/GTMValidatingContainers.h",
- "src/Foundation/GTMValidatingContainers.m",
"src/GTMDefines.h",
]
« no previous file with comments | « no previous file | third_party/google_toolbox_for_mac/google_toolbox_for_mac.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698