Download the Android SDK as a CIPD package

Download the Android SDK as a CIPD package

BUG=skia:5427
Committed: https://chromium.googlesource.com/chromium/tools/build/+/8933f172403d2eb94fbb6a1bf9f20616b5cd2411

[borenet, 2016-06-24 14:08:06]

borenet@google.com changed reviewers:
+ borenet@google.com, rmistry@chromium.org

[borenet, 2016-06-24 14:08:07]

Lands before https://codereview.chromium.org/2086003002/

[rmistry, 2016-06-24 14:17:04]

rmistry@google.com changed reviewers:
+ rmistry@google.com

[rmistry, 2016-06-24 14:17:04]

lgtm

[borenet, 2016-06-24 14:21:40]

On 2016/06/24 14:17:04, rmistry wrote:
> lgtm

Unfortunately this is blocked on https://github.com/luci/luci-go/issues/21.

[borenet, 2016-06-30 11:20:09]

On 2016/06/24 14:21:40, borenet wrote:
> On 2016/06/24 14:17:04, rmistry wrote:
> > lgtm
> 
> Unfortunately this is blocked on https://github.com/luci/luci-go/issues/21.

Dependencies have landed. PTAL.

[rmistry, 2016-06-30 11:27:41]

lgtm

https://codereview.chromium.org/2099713002/diff/40001/scripts/slave/recipe_mo...
File scripts/slave/recipe_modules/skia/android_flavor.py (right):

https://codereview.chromium.org/2099713002/diff/40001/scripts/slave/recipe_mo...
scripts/slave/recipe_modules/skia/android_flavor.py:72: 'android_sdk',
'android-sdk')
Two directories with different separators is... strange..

[borenet, 2016-06-30 11:33:39]

https://codereview.chromium.org/2099713002/diff/40001/scripts/slave/recipe_mo...
File scripts/slave/recipe_modules/skia/android_flavor.py (right):

https://codereview.chromium.org/2099713002/diff/40001/scripts/slave/recipe_mo...
scripts/slave/recipe_modules/skia/android_flavor.py:72: 'android_sdk',
'android-sdk')
On 2016/06/30 11:27:41, rmistry wrote:
> Two directories with different separators is... strange..

Yeah...

1. The CIPD package containing the Android SDK has the android-sdk directory at
the root level.  This is for cleanliness/sanity in case the package is unzipped
inside a directory containing other things.  "android-sdk" is named like the
"android-sdk-linux" and "android-sdk-macosx" directories you get when you
install the SDK on your machine.

2. We unzip the CIPD packages into named directories in case they don't follow
the rule in #1.  I named the CIPD package android_sdk.

I could change one of the two names, but the two-level directories are
protecting us from potential issues.

[rmistry, 2016-06-30 11:36:09]

On 2016/06/30 11:33:39, borenet wrote:
>
https://codereview.chromium.org/2099713002/diff/40001/scripts/slave/recipe_mo...
> File scripts/slave/recipe_modules/skia/android_flavor.py (right):
> 
>
https://codereview.chromium.org/2099713002/diff/40001/scripts/slave/recipe_mo...
> scripts/slave/recipe_modules/skia/android_flavor.py:72: 'android_sdk',
> 'android-sdk')
> On 2016/06/30 11:27:41, rmistry wrote:
> > Two directories with different separators is... strange..
> 
> Yeah...
> 
> 1. The CIPD package containing the Android SDK has the android-sdk directory
at
> the root level.  This is for cleanliness/sanity in case the package is
unzipped
> inside a directory containing other things.  "android-sdk" is named like the
> "android-sdk-linux" and "android-sdk-macosx" directories you get when you
> install the SDK on your machine.
> 
> 2. We unzip the CIPD packages into named directories in case they don't follow
> the rule in #1.  I named the CIPD package android_sdk.
> 
> I could change one of the two names, but the two-level directories are
> protecting us from potential issues.

Yea I figured there was a good reason for the two-level. Making the names
similar would be good though.

[borenet, 2016-06-30 11:51:35]

On 2016/06/30 11:36:09, rmistry wrote:
> On 2016/06/30 11:33:39, borenet wrote:
> >
>
https://codereview.chromium.org/2099713002/diff/40001/scripts/slave/recipe_mo...
> > File scripts/slave/recipe_modules/skia/android_flavor.py (right):
> > 
> >
>
https://codereview.chromium.org/2099713002/diff/40001/scripts/slave/recipe_mo...
> > scripts/slave/recipe_modules/skia/android_flavor.py:72: 'android_sdk',
> > 'android-sdk')
> > On 2016/06/30 11:27:41, rmistry wrote:
> > > Two directories with different separators is... strange..
> > 
> > Yeah...
> > 
> > 1. The CIPD package containing the Android SDK has the android-sdk directory
> at
> > the root level.  This is for cleanliness/sanity in case the package is
> unzipped
> > inside a directory containing other things.  "android-sdk" is named like the
> > "android-sdk-linux" and "android-sdk-macosx" directories you get when you
> > install the SDK on your machine.
> > 
> > 2. We unzip the CIPD packages into named directories in case they don't
follow
> > the rule in #1.  I named the CIPD package android_sdk.
> > 
> > I could change one of the two names, but the two-level directories are
> > protecting us from potential issues.
> 
> Yea I figured there was a good reason for the two-level. Making the names
> similar would be good though.

Leaving as-is per live discussion

[borenet, 2016-06-30 11:52:37]

On 2016/06/30 11:51:35, borenet wrote:
> On 2016/06/30 11:36:09, rmistry wrote:
> > On 2016/06/30 11:33:39, borenet wrote:
> > >
> >
>
https://codereview.chromium.org/2099713002/diff/40001/scripts/slave/recipe_mo...
> > > File scripts/slave/recipe_modules/skia/android_flavor.py (right):
> > > 
> > >
> >
>
https://codereview.chromium.org/2099713002/diff/40001/scripts/slave/recipe_mo...
> > > scripts/slave/recipe_modules/skia/android_flavor.py:72: 'android_sdk',
> > > 'android-sdk')
> > > On 2016/06/30 11:27:41, rmistry wrote:
> > > > Two directories with different separators is... strange..
> > > 
> > > Yeah...
> > > 
> > > 1. The CIPD package containing the Android SDK has the android-sdk
directory
> > at
> > > the root level.  This is for cleanliness/sanity in case the package is
> > unzipped
> > > inside a directory containing other things.  "android-sdk" is named like
the
> > > "android-sdk-linux" and "android-sdk-macosx" directories you get when you
> > > install the SDK on your machine.
> > > 
> > > 2. We unzip the CIPD packages into named directories in case they don't
> follow
> > > the rule in #1.  I named the CIPD package android_sdk.
> > > 
> > > I could change one of the two names, but the two-level directories are
> > > protecting us from potential issues.
> > 
> > Yea I figured there was a good reason for the two-level. Making the names
> > similar would be good though.
> 
> Leaving as-is per live discussion

Conclusion: package_names_use_lowercase_and_underscores, but package contents
are up to the package creator, in this case android-sdk matches the way the SDK
dir is typically named.

[borenet, 2016-06-30 11:52:43]

The CQ bit was checked by borenet@google.com

[commit-bot: I haz the power, 2016-06-30 11:52:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-30 11:56:53]

Description was changed from

==========
Download the Android SDK as a CIPD package

BUG=skia:5427
==========

to

==========
Download the Android SDK as a CIPD package

BUG=skia:5427

Committed:
https://chromium.googlesource.com/chromium/tools/build/+/8933f172403d2eb94fbb...
==========

[commit-bot: I haz the power, 2016-06-30 11:56:54]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/tools/build/+/8933f172403d2eb94fbb...