Download the Android SDK as a CIPD package

scripts/slave/recipes/skia/swarm_trigger.py

 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 
 # Recipe module for Skia Swarming trigger.
 
 
 import json
 
@@ skipping 150 matching lines @@
       skia_recipes_dir,
       'linux',
       'isolate_recipes',
       {})
   return api.skia_swarming.batcharchive(['isolate_recipes'])[0][1]
 
 
 def trigger_task(api, task_name, builder, master, slave, buildnumber,
                  builder_spec, got_revision, infrabots_dir, idempotent=False,
                  store_output=True, extra_isolate_hashes=None, expiration=None,
-                 hard_timeout=None, io_timeout=None):
+                 hard_timeout=None, io_timeout=None, cipd_packages=None):
   """Trigger the given bot to run as a Swarming task."""
   # TODO(borenet): We're using Swarming directly to run the recipe through
   # recipes.py. Once it's possible to track the state of a Buildbucket build,
   # we should switch to use the trigger recipe module instead.
 
   properties = {
     'buildername': builder,
     'mastername': master,
     'buildnumber': buildnumber,
     'reason': 'Triggered by Skia swarm_trigger Recipe',
@@ skipping 31 matching lines @@
       '%s_skia' % task_name,
       isolate_vars,
       dimensions,
       isolate_blacklist=isolate_blacklist,
       extra_isolate_hashes=extra_isolate_hashes,
       idempotent=idempotent,
       store_output=store_output,
       extra_args=extra_args,
       expiration=expiration,
       hard_timeout=hard_timeout,
-      io_timeout=io_timeout)
+      io_timeout=io_timeout,
+      cipd_packages=cipd_packages)
 
 
 def checkout_steps(api):
   """Run the steps to obtain a checkout of Skia."""
   gclient_cfg = api.gclient.make_config(CACHE_DIR=None)
   skia = gclient_cfg.solutions.add()
   skia.name = 'skia'
   skia.managed = False
   skia.url = 'https://skia.googlesource.com/skia.git'
   skia.revision = api.properties.get('revision') or 'origin/master'
@@ skipping 21 matching lines @@
       builder_spec,
       got_revision,
       infrabots_dir,
       idempotent=False,
       store_output=False,
       extra_isolate_hashes=extra_isolate_hashes)
   return api.skia_swarming.collect_swarming_task(task)
 
 
 def compile_steps_swarm(api, builder_spec, got_revision, infrabots_dir,
-                        extra_isolate_hashes):
+                        extra_isolate_hashes, cipd_packages):
   builder_name = derive_compile_bot_name(api.properties['buildername'],
                                          builder_spec)
   compile_builder_spec = builder_spec
   if builder_name != api.properties['buildername']:
     compile_builder_spec = api.skia.get_builder_spec(
         api.path['slave_build'].join('skia'), builder_name)
 
   extra_hashes = extra_isolate_hashes[:]
 
   # Windows bots require a toolchain.
@@ skipping 22 matching lines @@
       'compile',
       builder_name,
       master,
       slave,
       buildnumber,
       compile_builder_spec,
       got_revision,
       infrabots_dir,
       idempotent=True,
       store_output=False,
-      extra_isolate_hashes=extra_hashes)
+      extra_isolate_hashes=extra_hashes,
+      cipd_packages=cipd_packages)
 
   # Wait for compile to finish, record the results hash.
   return api.skia_swarming.collect_swarming_task_isolate_hash(task)
 
 
 def get_timeouts(builder_cfg):
   """Some builders require longer than the default timeouts.
 
   Returns tuple of (expiration, hard_timeout, io_timeout). If those values are
   none then default timeouts should be used.
   """
   expiration = None
   hard_timeout = None
   io_timeout = None
   if 'Valgrind' in builder_cfg.get('extra_config', ''):
     expiration = 2*24*60*60
     hard_timeout = 9*60*60
     io_timeout = 60*60
   return expiration, hard_timeout, io_timeout
 
 
 def perf_steps_trigger(api, builder_spec, got_revision, infrabots_dir,
-                       extra_hashes):
+                       extra_hashes, cipd_packages):
   """Trigger perf tests via Swarming."""
 
   expiration, hard_timeout, io_timeout = get_timeouts(
       builder_spec['builder_cfg'])
   return trigger_task(
       api,
       'perf',
       api.properties['buildername'],
       api.properties['mastername'],
       api.properties['slavename'],
       api.properties['buildnumber'],
       builder_spec,
       got_revision,
       infrabots_dir,
       extra_isolate_hashes=extra_hashes,
       expiration=expiration,
       hard_timeout=hard_timeout,
-      io_timeout=io_timeout)
+      io_timeout=io_timeout,
+      cipd_packages=cipd_packages)
 
 
 def perf_steps_collect(api, task, upload_perf_results, got_revision,
                        is_trybot):
   """Wait for perf steps to finish and upload results."""
   # Wait for nanobench to finish, download the results.
   api.file.rmtree('results_dir', task.task_output_dir, infra_step=True)
   api.skia_swarming.collect_swarming_task(task)
 
   # Upload the results.
@@ skipping 21 matching lines @@
     api.python(
              'Upload perf results',
              script=api.skia.resource('upload_bench_results.py'),
              args=upload_args,
              cwd=api.path['checkout'],
              env=api.skia.gsutil_env('chromium-skia-gm.boto'),
              infra_step=True)
 
 
 def test_steps_trigger(api, builder_spec, got_revision, infrabots_dir,
-                       extra_hashes):
+                       extra_hashes, cipd_packages):
   """Trigger DM via Swarming."""
   expiration, hard_timeout, io_timeout = get_timeouts(
       builder_spec['builder_cfg'])
   return trigger_task(
       api,
       'test',
       api.properties['buildername'],
       api.properties['mastername'],
       api.properties['slavename'],
       api.properties['buildnumber'],
       builder_spec,
       got_revision,
       infrabots_dir,
       extra_isolate_hashes=extra_hashes,
       expiration=expiration,
       hard_timeout=hard_timeout,
-      io_timeout=io_timeout)
+      io_timeout=io_timeout,
+      cipd_packages=cipd_packages)
 
 
 def test_steps_collect(api, task, upload_dm_results, got_revision, is_trybot,
                        builder_cfg):
   """Collect the test results from Swarming."""
   # Wait for tests to finish, download the results.
   api.file.rmtree('results_dir', task.task_output_dir, infra_step=True)
   api.skia_swarming.collect_swarming_task(task)
 
   # Upload the results.
@@ skipping 105 matching lines @@
   api.skia_swarming.setup(
       api.path['checkout'].join('infra', 'bots', 'tools', 'luci-go'),
       swarming_rev='')
 
   # Run gsutil.py to ensure that it's installed.
   api.gsutil(['help'])
 
   recipes_hash = isolate_recipes(api)
   extra_hashes = [recipes_hash]
 
+  # Get ready to compile.
+  compile_cipd_deps = []
+  extra_compile_hashes = [recipes_hash]
+
   # Android bots require an SDK.
   if 'Android' in api.properties['buildername']:
-    test_data = 'a27a70d73b85191b9e671ff2a44547c3f7cc15ee'
-    hash_file = infrabots_dir.join('android_sdk_hash')
-    # try/except as a temporary measure to prevent breakages for backfills
-    # and branches.
-    try:
-      h = api.skia._readfile(hash_file,
-                             name='Read android_sdk_hash',
-                             test_data=test_data).rstrip()
-    except api.step.StepFailure:
-      # Just fall back on the original hash.
-      h = 'a27a70d73b85191b9e671ff2a44547c3f7cc15ee'
-    extra_hashes.append(h)
+    android_sdk_version_file = infrabots_dir.join(
+        'assets', 'android_sdk', 'VERSION')
+    if api.path.exists(android_sdk_version_file):
+      android_sdk_version = api.skia._readfile(android_sdk_version_file,
+                                               name='read android_sdk VERSION',
+                                               test_data='0').rstrip()
+      android_sdk_version = 'version:%s' % android_sdk_version
+      pkg = ('android_sdk', 'skia/bots/android_sdk', android_sdk_version)
+      compile_cipd_deps.append(pkg)
+    else:
+      # TODO(borenet): Remove this legacy method after 7/1/2016.
+      test_data = 'a27a70d73b85191b9e671ff2a44547c3f7cc15ee'
+      hash_file = infrabots_dir.join('android_sdk_hash')
+      # try/except as a temporary measure to prevent breakages for backfills
+      # and branches.
+      try:
+        h = api.skia._readfile(hash_file,
+                               name='Read android_sdk_hash',
+                               test_data=test_data).rstrip()
+      except api.step.StepFailure:
+        # Just fall back on the original hash.
+        h = 'a27a70d73b85191b9e671ff2a44547c3f7cc15ee'
+      extra_hashes.append(h)
+      extra_compile_hashes.append(h)
 
+  # Compile.
   do_compile_steps = builder_spec.get('do_compile_steps', True)
-  compile_hash = None
   if do_compile_steps:
-    compile_hash = compile_steps_swarm(api, builder_spec, got_revision,
-                                       infrabots_dir, extra_hashes)
+    extra_hashes.append(compile_steps_swarm(
+        api, builder_spec, got_revision, infrabots_dir, extra_compile_hashes,
+        cipd_packages=compile_cipd_deps))
 
   if builder_cfg['role'] == 'Housekeeper':
     housekeeper_swarm(api, builder_spec, got_revision, infrabots_dir,
                       extra_hashes)
     return
 
+  # Get ready to test/perf.
+
+  # CIPD packages needed by test/perf.
+  cipd_packages = []
+
   do_test_steps = builder_spec['do_test_steps']
   do_perf_steps = builder_spec['do_perf_steps']
 
   if not (do_test_steps or do_perf_steps):
     return
 
-  if compile_hash:
-    extra_hashes.append(compile_hash)
-
   api.skia.download_skps(api.path['slave_build'].join('tmp'),
                          api.path['slave_build'].join('skps'))
   api.skia.download_images(api.path['slave_build'].join('tmp'),
                            api.path['slave_build'].join('images'))
 
   test_task = None
   perf_task = None
   if do_test_steps:
     test_task = test_steps_trigger(api, builder_spec, got_revision,
-                                   infrabots_dir, extra_hashes)
+                                   infrabots_dir, extra_hashes, cipd_packages)
   if do_perf_steps:
     perf_task = perf_steps_trigger(api, builder_spec, got_revision,
-                                   infrabots_dir, extra_hashes)
+                                   infrabots_dir, extra_hashes, cipd_packages)
   is_trybot = builder_cfg['is_trybot']
   if test_task:
     test_steps_collect(api, test_task, builder_spec['upload_dm_results'],
                        got_revision, is_trybot, builder_cfg)
   if perf_task:
     perf_steps_collect(api, perf_task, builder_spec['upload_perf_results'],
                        got_revision, is_trybot)
 
 
-def test_for_bot(api, builder, mastername, slavename, testname=None):
+def test_for_bot(api, builder, mastername, slavename, testname=None,
+                 legacy_android_sdk=False):
   """Generate a test for the given bot."""
   testname = testname or builder
   test = (
     api.test(testname) +
     api.properties(buildername=builder,
                    mastername=mastername,
                    slavename=slavename,
                    buildnumber=5,
                    revision='abc123') +
     api.path.exists(
         api.path['slave_build'].join('skia'),
         api.path['slave_build'].join('tmp', 'uninteresting_hashes.txt')
     )
   )
   if 'Trybot' in builder:
     test += api.properties(issue=500,
                            patchset=1,
                            rietveld='https://codereview.chromium.org')
+  if 'Android' in builder:
+    if not legacy_android_sdk:
+      test += api.path.exists(api.path['slave_build'].join(
+          'skia', 'infra', 'bots', 'assets', 'android_sdk', 'VERSION'))
   if 'Coverage' not in builder:
     test += api.step_data(
         'upload new .isolated file for compile_skia',
         stdout=api.raw_io.output('def456 XYZ.isolated'))
   if 'Test' in builder:
     test += api.step_data(
         'upload new .isolated file for test_skia',
         stdout=api.raw_io.output('def456 XYZ.isolated'))
   if ('Test' in builder and 'Debug' in builder) or 'Perf' in builder or (
       'Valgrind' in builder and 'Test' in builder):
@@ skipping 30 matching lines @@
   test += api.properties(test_downloaded_skp_version='999')
   test += api.path.exists(
       api.path['slave_build'].join('skia'),
       api.path['slave_build'].join('tmp', 'uninteresting_hashes.txt')
   )
   yield test
 
   builder = 'Build-Ubuntu-GCC-Arm7-Release-Android_Vulkan'
   master = 'client.skia.compile'
   slave = 'skiabot-linux-compile-000'
-  test = test_for_bot(api, builder, master, slave, 'Missing_android_sdk_hash')
+  test = test_for_bot(api, builder, master, slave, 'legacy_android_sdk',
+                      legacy_android_sdk=True)
+  test += api.step_data('Read android_sdk_hash',
+                        stdout=api.raw_io.output('<android_sdk_hash>'))
+  yield test
+
+  test = test_for_bot(api, builder, master, slave, 'Missing_android_sdk_hash',
+                      legacy_android_sdk=True)
   test += api.step_data('Read android_sdk_hash', retcode=1)
   yield test