Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 2099513002: [Typed OM] Rename TransformValue -> CSSTransformValue (Closed)

Created:
4 years, 6 months ago by meade_UTC10
Modified:
4 years, 5 months ago
Reviewers:
Timothy Loh
CC:
chromium-reviews, blink-reviews-style_chromium.org, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@rename-transformcomponent
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Typed OM] Rename TransformValue -> CSSTransformValue Spec: https://drafts.css-houdini.org/css-typed-om/#transformvalue-objects BUG=545318 Committed: https://crrev.com/8abd5bdb4c8f39af0eddcec75f5745e1d59f525f Cr-Commit-Position: refs/heads/master@{#402275}

Patch Set 1 #

Patch Set 2 : Update interface expectations #

Patch Set 3 : Change missed layout test #

Patch Set 4 : sync to head #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -251 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/worklet/webexposed/global-interface-listing-paint-worklet-expected.txt View 1 2 chunks +7 lines, -7 lines 0 comments Download
A + third_party/WebKit/LayoutTests/typedcssom/cssTransformValue.html View 2 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/LayoutTests/typedcssom/inlinestyle/transform.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/typedcssom/transformValue.html View 1 chunk +0 lines, -45 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 1 2 3 2 chunks +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/core.gypi View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
A + third_party/WebKit/Source/core/css/cssom/CSSTransformValue.h View 4 chunks +12 lines, -12 lines 0 comments Download
A + third_party/WebKit/Source/core/css/cssom/CSSTransformValue.cpp View 5 chunks +8 lines, -8 lines 0 comments Download
A + third_party/WebKit/Source/core/css/cssom/CSSTransformValue.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/cssom/StyleValueFactory.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
D third_party/WebKit/Source/core/css/cssom/TransformValue.h View 1 chunk +0 lines, -61 lines 0 comments Download
D third_party/WebKit/Source/core/css/cssom/TransformValue.cpp View 1 chunk +0 lines, -82 lines 0 comments Download
D third_party/WebKit/Source/core/css/cssom/TransformValue.idl View 1 chunk +0 lines, -13 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 9 (4 generated)
meade_UTC10
4 years, 6 months ago (2016-06-24 15:23:24 UTC) #2
Timothy Loh
On 2016/06/24 15:23:24, Eddy wrote: lgtm
4 years, 5 months ago (2016-06-27 00:05:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2099513002/60001
4 years, 5 months ago (2016-06-27 19:19:44 UTC) #6
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 5 months ago (2016-06-27 20:46:09 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-06-27 20:49:02 UTC) #9
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/8abd5bdb4c8f39af0eddcec75f5745e1d59f525f
Cr-Commit-Position: refs/heads/master@{#402275}

Powered by Google App Engine
This is Rietveld 408576698