Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Unified Diff: lib/src/runner/reporter/json.dart

Issue 2099503002: Add a dedicated Result for skipped tests. (Closed) Base URL: git@github.com:dart-lang/test@master
Patch Set: Code review changes Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/src/runner/reporter/expanded.dart ('k') | test/runner/engine_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/src/runner/reporter/json.dart
diff --git a/lib/src/runner/reporter/json.dart b/lib/src/runner/reporter/json.dart
index 6092aa2edf239cde5baa0da6f8a077ee6d2d108e..f30c206f9c52a956f4254dc63d985c8b00e8ec90 100644
--- a/lib/src/runner/reporter/json.dart
+++ b/lib/src/runner/reporter/json.dart
@@ -9,6 +9,7 @@ import '../../backend/group.dart';
import '../../backend/group_entry.dart';
import '../../backend/live_test.dart';
import '../../backend/metadata.dart';
+import '../../backend/state.dart';
import '../../backend/suite.dart';
import '../../backend/test_platform.dart';
import '../../frontend/expect.dart';
@@ -228,7 +229,11 @@ class JsonReporter implements Reporter {
void _onComplete(LiveTest liveTest) {
_emit("testDone", {
"testID": _liveTestIDs[liveTest],
- "result": liveTest.state.result.toString(),
+ // For backwards-compatibility, report skipped tests as successes.
+ "result": liveTest.state.result == Result.skipped
+ ? "success"
+ : liveTest.state.result.toString(),
+ "skipped": liveTest.state.result == Result.skipped,
"hidden": !_engine.liveTests.contains(liveTest)
});
}
« no previous file with comments | « lib/src/runner/reporter/expanded.dart ('k') | test/runner/engine_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698