Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Unified Diff: lib/src/runner/reporter/expanded.dart

Issue 2099503002: Add a dedicated Result for skipped tests. (Closed) Base URL: git@github.com:dart-lang/test@master
Patch Set: Code review changes Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/src/runner/reporter/compact.dart ('k') | lib/src/runner/reporter/json.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/src/runner/reporter/expanded.dart
diff --git a/lib/src/runner/reporter/expanded.dart b/lib/src/runner/reporter/expanded.dart
index b1ea93aaf781c519d7bc9a26b461d2d7aa630874..21d7c612f6ed134bf9a1f3190407b5a034f6ca97 100644
--- a/lib/src/runner/reporter/expanded.dart
+++ b/lib/src/runner/reporter/expanded.dart
@@ -194,7 +194,7 @@ class ExpandedReporter implements Reporter {
void _onStateChange(LiveTest liveTest, State state) {
if (state.status != Status.complete) return;
- if (liveTest.test.metadata.skip &&
+ if (state.result == Result.skipped &&
liveTest.test.metadata.skipReason != null) {
print(indent('${_yellow}Skip: ${liveTest.test.metadata.skipReason}'
'$_noColor'));
« no previous file with comments | « lib/src/runner/reporter/compact.dart ('k') | lib/src/runner/reporter/json.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698