Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(856)

Unified Diff: lib/src/runner/live_suite_controller.dart

Issue 2099503002: Add a dedicated Result for skipped tests. (Closed) Base URL: git@github.com:dart-lang/test@master
Patch Set: Code review changes Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/src/runner/engine.dart ('k') | lib/src/runner/reporter/compact.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/src/runner/live_suite_controller.dart
diff --git a/lib/src/runner/live_suite_controller.dart b/lib/src/runner/live_suite_controller.dart
index 4cacf2b94518f28f4867ee33534c146cf948fb80..a7d17688950883351cdccabaaab9b5723acdcb1b 100644
--- a/lib/src/runner/live_suite_controller.dart
+++ b/lib/src/runner/live_suite_controller.dart
@@ -121,11 +121,11 @@ class LiveSuiteController {
if (state.status != Status.complete) return;
_active = null;
- if (state.result != Result.success) {
+ if (state.result == Result.skipped) {
+ _skipped.add(liveTest);
+ } else if (state.result != Result.success) {
_passed.remove(liveTest);
_failed.add(liveTest);
- } else if (liveTest.test.metadata.skip) {
- _skipped.add(liveTest);
} else if (countSuccess) {
_passed.add(liveTest);
}
« no previous file with comments | « lib/src/runner/engine.dart ('k') | lib/src/runner/reporter/compact.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698