Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(527)

Issue 209933003: ARM64: push/pop registers in stubs for safepoints (Closed)

Created:
6 years, 9 months ago by vincent.belliard
Modified:
6 years, 9 months ago
Reviewers:
Benedikt Meurer, ulan
CC:
v8-dev
Visibility:
Public.

Description

ARM64: push/pop registers in stubs for safepoints BUG= R=ulan@chromium.org, bmeurer@chromium.org

Patch Set 1 #

Total comments: 10

Patch Set 2 : review fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+140 lines, -16 lines) Patch
M src/arm64/code-stubs-arm64.h View 1 chunk +31 lines, -0 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 1 2 chunks +51 lines, -0 lines 0 comments Download
M src/arm64/lithium-codegen-arm64.h View 1 2 chunks +22 lines, -10 lines 0 comments Download
M src/arm64/macro-assembler-arm64.h View 1 2 chunks +8 lines, -2 lines 0 comments Download
M src/arm64/macro-assembler-arm64.cc View 1 2 chunks +12 lines, -2 lines 0 comments Download
M src/code-stubs.h View 1 3 chunks +16 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
vincent.belliard
6 years, 9 months ago (2014-03-24 10:01:08 UTC) #1
ulan
https://codereview.chromium.org/209933003/diff/1/src/arm64/lithium-codegen-arm64.h File src/arm64/lithium-codegen-arm64.h (right): https://codereview.chromium.org/209933003/diff/1/src/arm64/lithium-codegen-arm64.h#newcode385 src/arm64/lithium-codegen-arm64.h:385: codegen_->masm_->Mov(to_be_pushed_lr, lr); to_be_pushed_lr is ip0, how do we guarantee ...
6 years, 9 months ago (2014-03-24 11:09:25 UTC) #2
vincent.belliard
https://codereview.chromium.org/209933003/diff/1/src/arm64/lithium-codegen-arm64.h File src/arm64/lithium-codegen-arm64.h (right): https://codereview.chromium.org/209933003/diff/1/src/arm64/lithium-codegen-arm64.h#newcode385 src/arm64/lithium-codegen-arm64.h:385: codegen_->masm_->Mov(to_be_pushed_lr, lr); On 2014/03/24 11:09:25, ulan wrote: > to_be_pushed_lr ...
6 years, 9 months ago (2014-03-24 11:16:59 UTC) #3
ulan
https://codereview.chromium.org/209933003/diff/1/src/arm64/lithium-codegen-arm64.h File src/arm64/lithium-codegen-arm64.h (right): https://codereview.chromium.org/209933003/diff/1/src/arm64/lithium-codegen-arm64.h#newcode385 src/arm64/lithium-codegen-arm64.h:385: codegen_->masm_->Mov(to_be_pushed_lr, lr); On 2014/03/24 11:16:59, vincent.belliard.arm wrote: > On ...
6 years, 9 months ago (2014-03-24 11:31:25 UTC) #4
vincent.belliard
https://codereview.chromium.org/209933003/diff/1/src/arm64/lithium-codegen-arm64.h File src/arm64/lithium-codegen-arm64.h (right): https://codereview.chromium.org/209933003/diff/1/src/arm64/lithium-codegen-arm64.h#newcode385 src/arm64/lithium-codegen-arm64.h:385: codegen_->masm_->Mov(to_be_pushed_lr, lr); On 2014/03/24 11:31:26, ulan wrote: > On ...
6 years, 9 months ago (2014-03-24 11:43:28 UTC) #5
ulan
https://codereview.chromium.org/209933003/diff/1/src/arm64/lithium-codegen-arm64.h File src/arm64/lithium-codegen-arm64.h (right): https://codereview.chromium.org/209933003/diff/1/src/arm64/lithium-codegen-arm64.h#newcode385 src/arm64/lithium-codegen-arm64.h:385: codegen_->masm_->Mov(to_be_pushed_lr, lr); On 2014/03/24 11:43:28, vincent.belliard.arm wrote: > On ...
6 years, 9 months ago (2014-03-24 12:23:50 UTC) #6
vincent.belliard
https://codereview.chromium.org/209933003/diff/1/src/arm64/lithium-codegen-arm64.h File src/arm64/lithium-codegen-arm64.h (right): https://codereview.chromium.org/209933003/diff/1/src/arm64/lithium-codegen-arm64.h#newcode385 src/arm64/lithium-codegen-arm64.h:385: codegen_->masm_->Mov(to_be_pushed_lr, lr); On 2014/03/24 12:23:51, ulan wrote: > On ...
6 years, 9 months ago (2014-03-24 16:03:52 UTC) #7
ulan
6 years, 9 months ago (2014-03-24 16:19:03 UTC) #8
lgtm

Powered by Google App Engine
This is Rietveld 408576698