ARM64: push/pop registers in stubs for safepoints

src/arm64/macro-assembler-arm64.h

 // Copyright 2013 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 1710 matching lines @@
                            Register addr,
                            Register scratch1,
                            SaveFPRegsMode save_fp,
                            RememberedSetFinalAction and_then);
 
   // Push and pop the registers that can hold pointers, as defined by the
   // RegList constant kSafepointSavedRegisters.
   void PushSafepointRegisters();
   void PopSafepointRegisters();
 
-  void PushSafepointFPRegisters();
-  void PopSafepointFPRegisters();
+  void PushSafepointRegistersAndDoubles();
+  void PopSafepointRegistersAndDoubles();
 
   // Store value in register src in the safepoint stack slot for register dst.
   void StoreToSafepointRegisterSlot(Register src, Register dst) {
     Poke(src, SafepointRegisterStackIndex(dst.code()) * kPointerSize);
   }
 
   // Load the value of the src register from its safepoint stack slot
   // into register dst.
   void LoadFromSafepointRegisterSlot(Register dst, Register src) {
     Peek(src, SafepointRegisterStackIndex(dst.code()) * kPointerSize);
@@ skipping 465 matching lines @@
 
   ~UseScratchRegisterScope();
 
   // Take a register from the appropriate temps list. It will be returned
   // automatically when the scope ends.
   Register AcquireW() { return AcquireNextAvailable(available_).W(); }
   Register AcquireX() { return AcquireNextAvailable(available_).X(); }
   FPRegister AcquireS() { return AcquireNextAvailable(availablefp_).S(); }
   FPRegister AcquireD() { return AcquireNextAvailable(availablefp_).D(); }
 
+  Register Acquire(const Register& reg) {

[ulan, 2014/03/24 12:23:51]

Please rename to UnsafeAcquire or something similar.

[vincent.belliard, 2014/03/24 16:03:52]

done

+    return AcquireFixed(available_, reg);
+  }
+  FPRegister Acquire(const FPRegister& reg) {
+    return AcquireFixed(availablefp_, reg);

[ulan, 2014/03/24 12:23:51]

It is not used and unsafe, please remove.

[vincent.belliard, 2014/03/24 16:03:52]

done

+  }
+
   Register AcquireSameSizeAs(const Register& reg);
   FPRegister AcquireSameSizeAs(const FPRegister& reg);
 
  private:
   static CPURegister AcquireNextAvailable(CPURegList* available);
+  static CPURegister AcquireFixed(CPURegList* available,
+                                  const CPURegister& reg);
 
   // Available scratch registers.
   CPURegList* available_;     // kRegister
   CPURegList* availablefp_;   // kFPRegister
 
   // The state of the available lists at the start of this scope.
   RegList old_available_;     // kRegister
   RegList old_availablefp_;   // kFPRegister
 };
 
@@ skipping 61 matching lines @@
 #error "Unsupported option"
 #define CODE_COVERAGE_STRINGIFY(x) #x
 #define CODE_COVERAGE_TOSTRING(x) CODE_COVERAGE_STRINGIFY(x)
 #define __FILE_LINE__ __FILE__ ":" CODE_COVERAGE_TOSTRING(__LINE__)
 #define ACCESS_MASM(masm) masm->stop(__FILE_LINE__); masm->
 #else
 #define ACCESS_MASM(masm) masm->
 #endif
 
 #endif  // V8_ARM64_MACRO_ASSEMBLER_ARM64_H_