Issue 209923002: ARM64: optimize call immediate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 209923002: ARM64: optimize call immediate (Closed)

Created:
6 years, 9 months ago by vincent.belliard

Modified:
6 years, 9 months ago

Reviewers:
Benedikt Meurer, ulan

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

ARM64: optimize call immediate BUG= R=ulan@chromium.org, bmeurer@chromium.org

Patch Set 2 : review fix #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -19 lines)			Patch
M	src/arm64/assembler-arm64.h	View	1	1 chunk	+7 lines, -8 lines	0 comments	Download
M	src/arm64/assembler-arm64-inl.h	View	1	2 chunks	+8 lines, -10 lines	0 comments	Download
M	src/arm64/macro-assembler-arm64.cc	View	1	1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ulan

https://codereview.chromium.org/209923002/diff/1/src/arm64/macro-assembler-arm64.cc File src/arm64/macro-assembler-arm64.cc (right): https://codereview.chromium.org/209923002/diff/1/src/arm64/macro-assembler-arm64.cc#newcode2027 src/arm64/macro-assembler-arm64.cc:2027: // Addresses are 48 bits so we never need ...

6 years, 9 months ago (2014-03-24 12:45:53 UTC) #2

lgtm, thanks for fixing it!

Expand Messages | Collapse Messages

Issue 209923002: ARM64: optimize call immediate (Closed)

Description

Patch Set 1 #

Patch Set 2 : review fix #

Messages