Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 2099083002: Convert video-pause* and video-plays* tests to testharness.js (Closed)

Created:
4 years, 5 months ago by Srirama
Modified:
4 years, 5 months ago
Reviewers:
fs, foolip
CC:
blink-reviews, chromium-reviews, eric.carlson_apple.com, feature-media-reviews_chromium.org, mlamouri+watch-blink_chromium.org, posciak+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert video-pause* and video-plays* tests to testharness.js Cleaning up video-pause* and video-plays* tests in media/ to use testharness.js instead of video-test.js. This will enable to upstream these tests to web-platform-tests. BUG=588956 Committed: https://crrev.com/3b01559831dac068d6043e331c7546017dd51567 Cr-Commit-Position: refs/heads/master@{#402085}

Patch Set 1 #

Patch Set 2 : fix #

Total comments: 2

Patch Set 3 : address comments #

Messages

Total messages: 12 (6 generated)
Srirama
PTAL
4 years, 5 months ago (2016-06-26 09:19:23 UTC) #3
fs
lgtm https://codereview.chromium.org/2099083002/diff/20001/third_party/WebKit/LayoutTests/media/video-plays-past-end-of-test.html File third_party/WebKit/LayoutTests/media/video-plays-past-end-of-test.html (right): https://codereview.chromium.org/2099083002/diff/20001/third_party/WebKit/LayoutTests/media/video-plays-past-end-of-test.html#newcode2 third_party/WebKit/LayoutTests/media/video-plays-past-end-of-test.html:2: <title>This test intentionally lets the video keep playing ...
4 years, 5 months ago (2016-06-26 15:20:09 UTC) #4
Srirama
https://codereview.chromium.org/2099083002/diff/20001/third_party/WebKit/LayoutTests/media/video-plays-past-end-of-test.html File third_party/WebKit/LayoutTests/media/video-plays-past-end-of-test.html (right): https://codereview.chromium.org/2099083002/diff/20001/third_party/WebKit/LayoutTests/media/video-plays-past-end-of-test.html#newcode2 third_party/WebKit/LayoutTests/media/video-plays-past-end-of-test.html:2: <title>This test intentionally lets the video keep playing past ...
4 years, 5 months ago (2016-06-26 18:36:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2099083002/40001
4 years, 5 months ago (2016-06-26 18:36:54 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-06-26 19:49:05 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-06-26 19:50:28 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/3b01559831dac068d6043e331c7546017dd51567
Cr-Commit-Position: refs/heads/master@{#402085}

Powered by Google App Engine
This is Rietveld 408576698