third_party/WebKit/LayoutTests/media/video-plays-past-end-of-test.html - Issue 2099083002: Convert video-pause* and video-plays* tests to testharness.js

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/media/video-plays-past-end-of-test.html

Issue 2099083002: Convert video-pause* and video-plays* tests to testharness.js (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/media/video-pause-immediately-expected.txt ('k') | third_party/WebKit/LayoutTests/media/video-plays-past-end-of-test-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <p>This test intentionally lets the video keep playing past endTest() to ensure	1 <!DOCTYPE html>

2 that shutdown is clean, since DumpRenderTree used to crash in this case.</p>	2 <title>This test intentionally lets the video keep playing past End of Test to e nsure
	fs 2016/06/26 15:20:08 Not sure there's much use "testharnessifying" this Not sure there's much use "testharnessifying" this test - could just eliminate the video-test bits from it. Srirama 2016/06/26 18:36:38 Done. Show quoted text On 2016/06/26 15:20:08, fs wrote: > Not sure there's much use "testharnessifying" this test - could just eliminate > the video-test bits from it. Done.
3	3 that shutdown is clean, since DumpRenderTree used to crash in this case.</title>

4 <video autoplay id="video"></video>	4 <script src="../resources/testharness.js"></script>

5 <script src=media-file.js></script>	5 <script src="../resources/testharnessreport.js"></script>

6 <!-- TODO(foolip): Convert test to testharness.js. crbug.com/588956	6 <script src="media-file.js"></script>

7 (Please avoid writing new tests using video-test.js) -->	7 <video autoplay></video>

8 <script src=video-test.js></script>	8 <script>

9 <script type="text/javascript">	9 async_test(function(t) {

10 if (window.testRunner)	10 var video = document.querySelector("video");

11 testRunner.dumpAsText();	11 testRunner.dumpAsText();

12 waitForEvent("playing", null, true);	12 video.onplaying = t.step_func_done();

13 video.src = findMediaFile("video", "content/test");	13 video.src = findMediaFile("video", "content/test");

14 </script>	14 });

	15 </script>

OLD	NEW