Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(479)

Issue 209893003: Only hightlight the part of suggestion string that has not been typed into input field in (Closed)

Created:
6 years, 9 months ago by ziran.sun
Modified:
6 years, 9 months ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews, benquan, jam, browser-components-watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Only hightlight the part of suggestion string that has not been typed into input field in autocomplete input field preview. By setting selectionRange from the end of the chracter/string typed into input field to the end of the suggested value, we only highlight the part that are not typed by the user. In this way, cursor will be at the end of the typed character/string. R=isherman@chromium.org BUG=355452 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=259013

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M components/autofill/content/renderer/autofill_agent.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
ziran.sun
Add selectionRange that only hight light the part of the suggestion value that has not ...
6 years, 9 months ago (2014-03-24 10:55:09 UTC) #1
Ilya Sherman
LGTM, thanks :)
6 years, 9 months ago (2014-03-24 17:38:21 UTC) #2
Ilya Sherman
The CQ bit was checked by isherman@chromium.org
6 years, 9 months ago (2014-03-24 17:38:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ziran.sun@samsung.com/209893003/1
6 years, 9 months ago (2014-03-24 17:38:42 UTC) #4
commit-bot: I haz the power
6 years, 9 months ago (2014-03-24 21:24:23 UTC) #5
Message was sent while issue was closed.
Change committed as 259013

Powered by Google App Engine
This is Rietveld 408576698