components/autofill/content/renderer/autofill_agent.cc - Issue 209893003: Only hightlight the part of suggestion string that has not been typed into input field in

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/content/renderer/autofill_agent.cc

Issue 209893003: Only hightlight the part of suggestion string that has not been typed into input field in (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/autofill/content/renderer/autofill_agent.cc

diff --git a/components/autofill/content/renderer/autofill_agent.cc b/components/autofill/content/renderer/autofill_agent.cc

index 5f3b03043eb0d6793db7fb47026ea428a26ab0ec..c3c9239bbacec1fc4ff78730f8453c33811ed659 100644

--- a/components/autofill/content/renderer/autofill_agent.cc

+++ b/components/autofill/content/renderer/autofill_agent.cc

@@ -601,6 +601,8 @@ void AutofillAgent::PreviewFieldWithValue(const base::string16& value,

was_query_node_autofilled_ = element_.isAutofilled();

node->setSuggestedValue(value.substr(0, node->maxLength()));

node->setAutofilled(true);

+ node->setSelectionRange(node->value().length(),

+ node->suggestedValue().length());

}

void AutofillAgent::HidePopup() {

« no previous file with comments | « no previous file | no next file » | no next file with comments »