Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(433)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 20989003: Deprecate FileSystemTaskRunners (Closed)

Created:
7 years, 4 months ago by kinuko
Modified:
7 years, 4 months ago
CC:
chromium-reviews, vandebo (ex-Chrome), jam, nkostylev+watch_chromium.org, Lei Zhang, tfarina, Greg Billock, joi+watch-content_chromium.org, tommycli, darin-cc_chromium.org, oshima+watch_chromium.org, tzik+watch_chromium.org, markusheintz_, stevenjb+watch_chromium.org, kinuko+watch, davemoore+watch_chromium.org
Visibility:
Public.

Description

Deprecate FileSystemTaskRunners Now it only has two members, IO and default file task runner, and only file runner accessor is used. BUG=266232 TEST=compile R=satorux@chromium.org, tzik@chromium.org, vandebo@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=215538

Patch Set 1 : rebase #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -163 lines) Patch
M chrome/browser/browsing_data/browsing_data_file_system_helper.cc View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system_backend_delegate.cc View 3 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system_util_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/fileapi/file_system_backend.cc View 1 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/media_galleries/fileapi/media_file_system_backend.cc View 1 3 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/media_galleries/fileapi/native_media_file_util.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/media_galleries/fileapi/native_media_file_util_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/media_galleries/fileapi/picasa/picasa_file_util_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/fileapi/browser_file_system_helper.cc View 4 chunks +3 lines, -8 lines 0 comments Download
M content/browser/fileapi/fileapi_message_filter.cc View 1 3 chunks +2 lines, -3 lines 0 comments Download
M webkit/browser/fileapi/file_system_context.h View 1 6 chunks +11 lines, -7 lines 0 comments Download
M webkit/browser/fileapi/file_system_context.cc View 1 6 chunks +9 lines, -10 lines 0 comments Download
M webkit/browser/fileapi/file_system_context_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/browser/fileapi/file_system_file_stream_reader.cc View 2 chunks +1 line, -2 lines 0 comments Download
M webkit/browser/fileapi/file_system_operation_context.cc View 1 chunk +1 line, -2 lines 0 comments Download
M webkit/browser/fileapi/file_system_operation_impl.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M webkit/browser/fileapi/file_system_quota_client.cc View 2 chunks +1 line, -2 lines 0 comments Download
D webkit/browser/fileapi/file_system_task_runners.h View 1 chunk +0 lines, -47 lines 0 comments Download
D webkit/browser/fileapi/file_system_task_runners.cc View 1 chunk +0 lines, -30 lines 0 comments Download
M webkit/browser/fileapi/isolated_file_system_backend.cc View 1 3 chunks +2 lines, -3 lines 0 comments Download
M webkit/browser/fileapi/isolated_file_util_unittest.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M webkit/browser/fileapi/mock_file_system_context.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/browser/fileapi/obfuscated_file_util_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webkit/browser/fileapi/sandbox_file_stream_writer.cc View 2 chunks +1 line, -2 lines 0 comments Download
M webkit/browser/fileapi/sandbox_file_system_backend.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M webkit/browser/fileapi/sandbox_file_system_test_helper.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M webkit/browser/fileapi/syncable/canned_syncable_file_system.cc View 1 2 chunks +2 lines, -4 lines 0 comments Download
M webkit/browser/fileapi/syncable/local_file_change_tracker_unittest.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M webkit/browser/fileapi/syncable/local_file_sync_context.cc View 1 9 chunks +12 lines, -13 lines 0 comments Download
M webkit/browser/fileapi/syncable/syncable_file_system_unittest.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M webkit/storage_browser.gyp View 1 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
kinuko
Mechanical cleanup only. Can you review? satorux: c/b/chromeos/* vandebo: c/b/media_galleries/* tzik: fileapi in general
7 years, 4 months ago (2013-08-01 10:32:33 UTC) #1
vandebo (ex-Chrome)
c/b/media_galleries/* LGTM
7 years, 4 months ago (2013-08-01 14:35:53 UTC) #2
tzik
lgtm
7 years, 4 months ago (2013-08-02 02:25:59 UTC) #3
satorux1
chrome/browser/chromeos/ lgtm
7 years, 4 months ago (2013-08-02 03:06:37 UTC) #4
kinuko
7 years, 4 months ago (2013-08-04 08:02:51 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 manually as r215538.

Powered by Google App Engine
This is Rietveld 408576698