Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 2098853003: Merge M52: "Restrict OnSuspend() restrictions for audio to non-Android." (Closed)

Created:
4 years, 6 months ago by DaleCurtis
Modified:
4 years, 6 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2743
Target Ref:
refs/pending/branch-heads/2743
Project:
chromium
Visibility:
Public.

Description

Merge M52: "Restrict OnSuspend() restrictions for audio to non-Android." On Android suspend and resume work differently than other platforms, the notifications are delivered a few seconds after an app is put into the background. We don't want to suspend background audio in these cases; full player suspend and resume is controlled by the WebMediaPlayerImpl instead when necessary (video only, paused, etc). BUG=623066 TEST=background page in bug, audio plays forever. Review-Url: https://codereview.chromium.org/2098703005 Cr-Commit-Position: refs/heads/master@{#402034} (cherry picked from commit a11de20c793b16d4dc4e5440097f8493666f0721) Committed: https://chromium.googlesource.com/chromium/src/+/84a0e4c0a9d8b6e2ba2850ee50f5d8612deff691

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M media/renderers/audio_renderer_impl.cc View 3 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
DaleCurtis
4 years, 6 months ago (2016-06-25 01:13:09 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
84a0e4c0a9d8b6e2ba2850ee50f5d8612deff691.

Powered by Google App Engine
This is Rietveld 408576698