Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(731)

Issue 2098703005: Restrict OnSuspend() restrictions for audio to non-Android. (Closed)

Created:
4 years, 6 months ago by DaleCurtis
Modified:
4 years, 6 months ago
Reviewers:
watk, xhwang
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Restrict OnSuspend() restrictions for audio to non-Android. On Android suspend and resume work differently than other platforms, the notifications are delivered a few seconds after an app is put into the background. We don't want to suspend background audio in these cases; full player suspend and resume is controlled by the WebMediaPlayerImpl instead when necessary (video only, paused, etc). BUG=623066 TEST=manual Committed: https://crrev.com/a11de20c793b16d4dc4e5440097f8493666f0721 Cr-Commit-Position: refs/heads/master@{#402034}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M media/renderers/audio_renderer_impl.cc View 3 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
DaleCurtis
4 years, 6 months ago (2016-06-24 17:33:13 UTC) #2
watk
lgtm
4 years, 6 months ago (2016-06-24 23:35:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2098703005/1
4 years, 6 months ago (2016-06-24 23:37:20 UTC) #6
xhwang
LGTM Do we know whether suspend/resume exist or how they work on other platform, e.g. ...
4 years, 6 months ago (2016-06-24 23:48:24 UTC) #7
DaleCurtis
All the desktop platforms work the same, suspend is only sent when machine is going ...
4 years, 6 months ago (2016-06-24 23:51:01 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-25 00:54:04 UTC) #9
commit-bot: I haz the power
4 years, 6 months ago (2016-06-25 00:56:12 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a11de20c793b16d4dc4e5440097f8493666f0721
Cr-Commit-Position: refs/heads/master@{#402034}

Powered by Google App Engine
This is Rietveld 408576698