Issue 209873005: Replaced unreachable code in DoStoreNamedField by an assertion.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 209873005: Replaced unreachable code in DoStoreNamedField by an assertion. (Closed)

Created:
6 years, 9 months ago by Sven Panne

Modified:
6 years, 9 months ago

Reviewers:
Toon Verwaest

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Replaced unreachable code in DoStoreNamedField by an assertion. This is part of the effort to assign an environment if and only if we can deopt. Removed some related dead code on the way. R=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20194

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -30 lines)			Patch
M	src/arm/lithium-codegen-arm.cc	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/arm64/lithium-codegen-arm64.cc	View	1	2 chunks	+4 lines, -2 lines	0 comments	Download
M	src/ia32/lithium-codegen-ia32.cc	View		1 chunk	+4 lines, -8 lines	0 comments	Download
M	src/x64/lithium-codegen-x64.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	src/x64/lithium-codegen-x64.cc	View		2 chunks	+6 lines, -19 lines	0 comments	Download

Total messages: 3 (0 generated)

Sven Panne

6 years, 9 months ago (2014-03-24 13:16:31 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r20194 (presubmit successful).