src/arm/lithium-codegen-arm.cc - Issue 209873005: Replaced unreachable code in DoStoreNamedField by an assertion.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/arm/lithium-codegen-arm.cc

Issue 209873005: Replaced unreachable code in DoStoreNamedField by an assertion. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Simplified Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/arm/lithium-codegen-arm.cc

diff --git a/src/arm/lithium-codegen-arm.cc b/src/arm/lithium-codegen-arm.cc

index c2dfde3cc4a5a84c4ac4655d9e8da061f8d2077d..0fe38a0c2b398833723622c2e2b84ff24e6ee9b4 100644

--- a/src/arm/lithium-codegen-arm.cc

+++ b/src/arm/lithium-codegen-arm.cc

@@ -4033,6 +4033,9 @@ void LCodeGen::DoStoreNamedField(LStoreNamedField* instr) {

instr->hydrogen()->value()->IsHeapObject()

? OMIT_SMI_CHECK : INLINE_SMI_CHECK;

+ ASSERT(!(representation.IsSmi() &&

+ instr->value()->IsConstantOperand() &&

+ !IsSmi(LConstantOperand::cast(instr->value()))));

if (representation.IsHeapObject()) {

if (!instr->hydrogen()->value()->type().IsHeapObject()) {

« no previous file with comments | « no previous file | src/arm64/lithium-codegen-arm64.cc » ('j') | no next file with comments »