chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManager.java - Issue 2098683002: Refactor OverlayPanel height calculations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManager.java

Issue 2098683002: Refactor OverlayPanel height calculations (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix tests Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/Layout.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/ReaderModeManager.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManager.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManager.java b/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManager.java

index 7885266fb69d53ff38365068d525d1de6b98da51..6f8b0b3c529b31a800c5c886b6a6b131249a2af4 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManager.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManager.java

@@ -287,8 +287,8 @@ public abstract class LayoutManager implements LayoutUpdateHost, LayoutProvider,

protected void onViewportChanged(RectF viewportDp) {

if (getActiveLayout() != null) {

- getActiveLayout().sizeChanged(viewportDp, mLastVisibleViewportDp,

- mLastFullscreenViewportDp, mLastHeightMinusTopControlsDp, getOrientation());

+ getActiveLayout().sizeChanged(mLastVisibleViewportDp, mLastFullscreenViewportDp,

+ mLastHeightMinusTopControlsDp, getOrientation());

}