Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2047)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/Layout.java

Issue 2098683002: Refactor OverlayPanel height calculations (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix tests Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/Layout.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/Layout.java b/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/Layout.java
index 657c0f2398b34538bb8dcfc1848a153676474a46..5911207282e7da430359c4f1a75159b4f1c1f39f 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/Layout.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/Layout.java
@@ -362,7 +362,6 @@ public abstract class Layout implements TabContentManager.ThumbnailChangeListene
/**
* Called when the size of the viewport has changed.
- * @param availableViewport The actual viewport this {@link Layout} should be rendering to.
* @param visibleViewport The visible viewport that represents the area on the screen
* this {@link Layout} gets to draw to (potentially takes into
* account top controls).
@@ -372,12 +371,11 @@ public abstract class Layout implements TabContentManager.ThumbnailChangeListene
* @param orientation The new orientation. Valid values are defined by
* {@link Orientation}.
*/
- public final void sizeChanged(RectF availableViewport, RectF visibleViewport,
- RectF screenViewport, float heightMinusTopControls, int orientation) {
- // 1. Pull out this Layout's specific width and height properties based on the available
- // viewport.
- float width = availableViewport.width();
- float height = availableViewport.height();
+ public final void sizeChanged(RectF visibleViewport, RectF screenViewport,
+ float heightMinusTopControls, int orientation) {
+ // 1. Pull out this Layout's width and height properties based on the viewport.
+ float width = screenViewport.width();
+ float height = screenViewport.height();
// 2. Check if any Layout-specific properties have changed.
boolean layoutPropertiesChanged = mWidth != width

Powered by Google App Engine
This is Rietveld 408576698