Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Unified Diff: third_party/WebKit/Source/modules/BUILD.gn

Issue 2098673002: Make GN components static libraries on Win x64 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: blink_modules Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/config/BUILDCONFIG.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/modules/BUILD.gn
diff --git a/third_party/WebKit/Source/modules/BUILD.gn b/third_party/WebKit/Source/modules/BUILD.gn
index e907a8bca713885647d85b7f62062bac33ac9573..97160266958fd5bb8094c64b11d892c91a24c2f0 100644
--- a/third_party/WebKit/Source/modules/BUILD.gn
+++ b/third_party/WebKit/Source/modules/BUILD.gn
@@ -14,6 +14,14 @@ visibility = [ "//third_party/WebKit/Source/*" ]
component("modules") {
output_name = "blink_modules"
+ if (is_win && is_official_build) {
+ # This target is >2GB for official builds on Windows which causes linking
+ # with the library to fail. As a workaround, force using a source set in
+ # this configuration whcih avoids generating the .lib file (although will
+ # cause slower links).
+ static_component_type = "source_set"
+ }
+
visibility = [] # Allow re-assignment of list.
visibility = [ "//third_party/WebKit/*" ]
« no previous file with comments | « build/config/BUILDCONFIG.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698