Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(530)

Unified Diff: build/config/BUILDCONFIG.gn

Issue 2098673002: Make GN components static libraries on Win x64 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: blink_modules Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/BUILDCONFIG.gn
diff --git a/build/config/BUILDCONFIG.gn b/build/config/BUILDCONFIG.gn
index af9fac390bb5542061f04157c2a8579db88edff9..554249f24ead16ccc46db8667a06af647e69f0b0 100644
--- a/build/config/BUILDCONFIG.gn
+++ b/build/config/BUILDCONFIG.gn
@@ -633,15 +633,10 @@ template("component") {
assert(invoker.static_component_type == "static_library" ||
invoker.static_component_type == "source_set")
_component_mode = invoker.static_component_type
- } else if (!defined(invoker.sources) || is_mac ||
- (is_win && is_official_build)) {
+ } else if (!defined(invoker.sources) || is_mac) {
# When there are no sources defined, use a source set to avoid creating
# an empty static library (which generally don't work).
#
- # On Windows official builds, the link time code generation bloats static
- # libraries to the point where some of them become >32 bits large which
- # causes lib.exe to fail. Always use source sets for that configuration.
- #
# TODO(brettw) bug 618797: Remove the mac condition. On Mac making these as
# static_library causes crashes. Remove the mac condition above when this
# is fixed.
« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698