Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(704)

Issue 2098673002: Make GN components static libraries on Win x64 (Closed)

Created:
4 years, 6 months ago by brettw
Modified:
4 years, 6 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make GN components static libraries on Win x64 For the static builds, previously there was a static library exception for the windows official builds. They were source sets instead on the theory that some of them could get over 2GB. There's only one component over 2GB (blink_modules). The rest of the targets that were too large before were all explicit static libraries which have been dealt with already. This change whitelists blink_modules. After that, the largest static library is now blink_platform (1.2GB). The rest are less than 1 GB. So we can now disable the special case for this configuration. BUG=619949 Committed: https://crrev.com/d28aba56dde82051680f9048daf1b1501b9bd89a Cr-Commit-Position: refs/heads/master@{#401800}

Patch Set 1 #

Patch Set 2 : blink_modules #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -6 lines) Patch
M build/config/BUILDCONFIG.gn View 1 chunk +1 line, -6 lines 0 comments Download
M third_party/WebKit/Source/modules/BUILD.gn View 1 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (12 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2098673002/1
4 years, 6 months ago (2016-06-23 22:26:12 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2098673002/20001
4 years, 6 months ago (2016-06-23 22:52:36 UTC) #8
Dirk Pranke
lgtm lgtm
4 years, 6 months ago (2016-06-23 23:12:03 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2098673002/20001
4 years, 6 months ago (2016-06-23 23:17:01 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/251644)
4 years, 6 months ago (2016-06-24 00:16:49 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2098673002/20001
4 years, 6 months ago (2016-06-24 00:29:41 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-24 03:04:43 UTC) #18
commit-bot: I haz the power
4 years, 6 months ago (2016-06-24 03:07:09 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d28aba56dde82051680f9048daf1b1501b9bd89a
Cr-Commit-Position: refs/heads/master@{#401800}

Powered by Google App Engine
This is Rietveld 408576698