|
|
Created:
4 years, 6 months ago by brettw Modified:
4 years, 6 months ago Reviewers:
Dirk Pranke CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionMake GN components static libraries on Win x64
For the static builds, previously there was a static library exception for the windows official builds. They were source sets instead on the theory that some of them could get over 2GB.
There's only one component over 2GB (blink_modules). The rest of the targets that were too large before were all explicit static libraries which have been dealt with already. This change whitelists blink_modules. After that, the largest static library is now blink_platform (1.2GB). The rest are less than 1 GB.
So we can now disable the special case for this configuration.
BUG=619949
Committed: https://crrev.com/d28aba56dde82051680f9048daf1b1501b9bd89a
Cr-Commit-Position: refs/heads/master@{#401800}
Patch Set 1 #Patch Set 2 : blink_modules #
Messages
Total messages: 20 (12 generated)
Description was changed from ========== Make GN components static libraries on Win x64 For the static builds, previously there was a static library exception for the windows official builds. They were source sets instead on the theory that some of them could get over 4GB. However, it looks like there are no components this large in a static build. The targets that were too large before were all explicit static libraries which have been dealt with already. The two larges static libraries are now blink_modules (3.1GB) and blink_platform (1.2GB). The rest are less than 1 GB. So we can now disable the special case for this configuration. BUG= ========== to ========== Make GN components static libraries on Win x64 For the static builds, previously there was a static library exception for the windows official builds. They were source sets instead on the theory that some of them could get over 4GB. However, it looks like there are no components this large in a static build. The targets that were too large before were all explicit static libraries which have been dealt with already. The two larges static libraries are now blink_modules (3.1GB) and blink_platform (1.2GB). The rest are less than 1 GB. So we can now disable the special case for this configuration. BUG=619949 ==========
brettw@chromium.org changed reviewers: + dpranke@chromium.org
The CQ bit was checked by brettw@chromium.org to run a CQ dry run
Description was changed from ========== Make GN components static libraries on Win x64 For the static builds, previously there was a static library exception for the windows official builds. They were source sets instead on the theory that some of them could get over 4GB. However, it looks like there are no components this large in a static build. The targets that were too large before were all explicit static libraries which have been dealt with already. The two larges static libraries are now blink_modules (3.1GB) and blink_platform (1.2GB). The rest are less than 1 GB. So we can now disable the special case for this configuration. BUG=619949 ========== to ========== Make GN components static libraries on Win x64 For the static builds, previously there was a static library exception for the windows official builds. They were source sets instead on the theory that some of them could get over 4GB. However, it looks like there are no components this large in a static build. The targets that were too large before were all explicit static libraries which have been dealt with already. The two largest static libraries are now blink_modules (3.1GB) and blink_platform (1.2GB). The rest are less than 1 GB. So we can now disable the special case for this configuration. BUG=619949 ==========
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2098673002/1
Description was changed from ========== Make GN components static libraries on Win x64 For the static builds, previously there was a static library exception for the windows official builds. They were source sets instead on the theory that some of them could get over 4GB. However, it looks like there are no components this large in a static build. The targets that were too large before were all explicit static libraries which have been dealt with already. The two largest static libraries are now blink_modules (3.1GB) and blink_platform (1.2GB). The rest are less than 1 GB. So we can now disable the special case for this configuration. BUG=619949 ========== to ========== Make GN components static libraries on Win x64 For the static builds, previously there was a static library exception for the windows official builds. They were source sets instead on the theory that some of them could get over 2GB. There's only one component over 2GB (blink_modules). The rest of the targets that were too large before were all explicit static libraries which have been dealt with already. This change whitelists blink_modules. After that, the largest static library is now blink_platform (1.2GB). The rest are less than 1 GB. So we can now disable the special case for this configuration. BUG=619949 ==========
The CQ bit was checked by brettw@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2098673002/20001
lgtm lgtm
The CQ bit was unchecked by brettw@chromium.org
The CQ bit was checked by brettw@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2098673002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by dpranke@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2098673002/20001
Message was sent while issue was closed.
Description was changed from ========== Make GN components static libraries on Win x64 For the static builds, previously there was a static library exception for the windows official builds. They were source sets instead on the theory that some of them could get over 2GB. There's only one component over 2GB (blink_modules). The rest of the targets that were too large before were all explicit static libraries which have been dealt with already. This change whitelists blink_modules. After that, the largest static library is now blink_platform (1.2GB). The rest are less than 1 GB. So we can now disable the special case for this configuration. BUG=619949 ========== to ========== Make GN components static libraries on Win x64 For the static builds, previously there was a static library exception for the windows official builds. They were source sets instead on the theory that some of them could get over 2GB. There's only one component over 2GB (blink_modules). The rest of the targets that were too large before were all explicit static libraries which have been dealt with already. This change whitelists blink_modules. After that, the largest static library is now blink_platform (1.2GB). The rest are less than 1 GB. So we can now disable the special case for this configuration. BUG=619949 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Make GN components static libraries on Win x64 For the static builds, previously there was a static library exception for the windows official builds. They were source sets instead on the theory that some of them could get over 2GB. There's only one component over 2GB (blink_modules). The rest of the targets that were too large before were all explicit static libraries which have been dealt with already. This change whitelists blink_modules. After that, the largest static library is now blink_platform (1.2GB). The rest are less than 1 GB. So we can now disable the special case for this configuration. BUG=619949 ========== to ========== Make GN components static libraries on Win x64 For the static builds, previously there was a static library exception for the windows official builds. They were source sets instead on the theory that some of them could get over 2GB. There's only one component over 2GB (blink_modules). The rest of the targets that were too large before were all explicit static libraries which have been dealt with already. This change whitelists blink_modules. After that, the largest static library is now blink_platform (1.2GB). The rest are less than 1 GB. So we can now disable the special case for this configuration. BUG=619949 Committed: https://crrev.com/d28aba56dde82051680f9048daf1b1501b9bd89a Cr-Commit-Position: refs/heads/master@{#401800} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/d28aba56dde82051680f9048daf1b1501b9bd89a Cr-Commit-Position: refs/heads/master@{#401800} |