Add ink drop highlight for hover and focus on location icons (e.g. star,

Add ink drop highlight for hover and focus on location icons (e.g. star,
zoom, translate, passwords) and content settings icon.

This doesn't do anything for other icon label bubble views (like the
location icon). Some of the code in ContentSettingImageView should
probably be moved into IconLabelBubbleView for that. Also, there's no
hover or focus effect when the label is showing (e.g. when Chrome first
blocks a popup and there's text next to the icon). Since it remains
unclear to me how the hover and press effects should look in this
scenario, limit the ink drop to when only the icon is visible.

BUG=591140
Committed: https://crrev.com/fc47fab1198649e7e3c7e447db6453ae7f2ba612
Cr-Commit-Position: refs/heads/master@{#403170}

[Evan Stade, 2016-06-23 21:34:51]

estade@chromium.org changed reviewers:
+ pkasting@chromium.org, varkha@chromium.org

[Evan Stade, 2016-06-27 15:49:28]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-27 15:49:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-27 16:47:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-27 16:47:49]

Dry run: This issue passed the CQ dry run.

[Evan Stade, 2016-06-29 22:33:28]

ping

[Peter Kasting, 2016-06-29 23:39:38]

LGTM.  Bonus if you can next easily refactor to have this apply to other
IconLabelBubbleViews.

[Evan Stade, 2016-06-30 13:38:52]

On 2016/06/29 23:39:38, Peter Kasting (slow) wrote:
> LGTM.  Bonus if you can next easily refactor to have this apply to other
> IconLabelBubbleViews.

Yea, I would like to make that improvement, although only the location icon will
actually benefit from it.

[Evan Stade, 2016-06-30 13:38:59]

The CQ bit was checked by estade@chromium.org

[commit-bot: I haz the power, 2016-06-30 13:39:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-30 14:23:20]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-30 14:23:22]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-06-30 14:25:28]

Description was changed from

==========
Add ink drop highlight for hover and focus on location icons (e.g. star,
zoom, translate, passwords) and content settings icon.

This doesn't do anything for other icon label bubble views (like the
location icon). Some of the code in ContentSettingImageView should
probably be moved into IconLabelBubbleView for that. Also, there's no
hover or focus effect when the label is showing (e.g. when Chrome first
blocks a popup and there's text next to the icon). Since it remains
unclear to me how the hover and press effects should look in this
scenario, limit the ink drop to when only the icon is visible.

BUG=591140
==========

to

==========
Add ink drop highlight for hover and focus on location icons (e.g. star,
zoom, translate, passwords) and content settings icon.

This doesn't do anything for other icon label bubble views (like the
location icon). Some of the code in ContentSettingImageView should
probably be moved into IconLabelBubbleView for that. Also, there's no
hover or focus effect when the label is showing (e.g. when Chrome first
blocks a popup and there's text next to the icon). Since it remains
unclear to me how the hover and press effects should look in this
scenario, limit the ink drop to when only the icon is visible.

BUG=591140

Committed: https://crrev.com/fc47fab1198649e7e3c7e447db6453ae7f2ba612
Cr-Commit-Position: refs/heads/master@{#403170}
==========

[commit-bot: I haz the power, 2016-06-30 14:25:29]

Patchset 2 (id:??) landed as
https://crrev.com/fc47fab1198649e7e3c7e447db6453ae7f2ba612
Cr-Commit-Position: refs/heads/master@{#403170}