chrome/browser/ui/views/location_bar/bubble_icon_view.cc - Issue 2098643002: Add ink drop highlight for hover and focus on location icons (e.g. star,

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/location_bar/bubble_icon_view.cc

Issue 2098643002: Add ink drop highlight for hover and focus on location icons (e.g. star, (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: docs Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/location_bar/bubble_icon_view.h ('k') | chrome/browser/ui/views/location_bar/content_setting_image_view.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/location_bar/bubble_icon_view.cc

diff --git a/chrome/browser/ui/views/location_bar/bubble_icon_view.cc b/chrome/browser/ui/views/location_bar/bubble_icon_view.cc

index c444502114848374e1ddc0117c2a3c593ad777e1..2cc0c63027a9dc2071b6c305227e9a03e70e0911 100644

--- a/chrome/browser/ui/views/location_bar/bubble_icon_view.cc

+++ b/chrome/browser/ui/views/location_bar/bubble_icon_view.cc

@@ -145,12 +145,6 @@ void BubbleIconView::RemoveInkDropLayer(ui::Layer* ink_drop_layer) {

image_->SetPaintToLayer(false);

}

-std::unique_ptr<views::InkDropHighlight>

-BubbleIconView::CreateInkDropHighlight() const {

- // BubbleIconView views don't show hover effect.

- return HasFocus() ? InkDropHostView::CreateInkDropHighlight() : nullptr;

SkColor BubbleIconView::GetInkDropBaseColor() const {

return color_utils::DeriveDefaultIconColor(GetNativeTheme()->GetSystemColor(

ui::NativeTheme::kColorId_TextfieldDefaultColor));