Source/web/tests/WebInputEventFactoryTestGtk.cpp - Issue 20986003: Define DOM_KEY_LOCATION_* constants on KeyboardEvent

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/tests/WebInputEventFactoryTestGtk.cpp

Issue 20986003: Define DOM_KEY_LOCATION_* constants on KeyboardEvent (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Fix nits Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/web/tests/WebInputEventFactoryTestGtk.cpp

diff --git a/Source/web/tests/WebInputEventFactoryTestGtk.cpp b/Source/web/tests/WebInputEventFactoryTestGtk.cpp

index 47f8cc83dee777c80e1a071907620f7635f34e53..c133a4b6e417fda2d98d2bc121f622b419021c4e 100644

--- a/Source/web/tests/WebInputEventFactoryTestGtk.cpp

+++ b/Source/web/tests/WebInputEventFactoryTestGtk.cpp

@@ -194,7 +194,7 @@ TEST(WebInputEventFactoryTest, NumPadConversion)

// Round-trip through the WebCore KeyboardEvent class.

WebKit::PlatformKeyboardEventBuilder platformBuilder(webEvent);

RefPtr<WebCore::KeyboardEvent> keypress = WebCore::KeyboardEvent::create(platformBuilder, 0);

- EXPECT_TRUE(keypress->keyLocation() == WebCore::KeyboardEvent::DOMKeyLocationNumpad);

+ EXPECT_TRUE(keypress->keyLocation() == WebCore::KeyboardEvent::DOM_KEY_LOCATION_NUMPAD);

WebKit::WebKeyboardEventBuilder builder(*keypress);

EXPECT_TRUE(builder.modifiers & WebInputEvent::IsKeyPad);