Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(815)

Unified Diff: Source/core/dom/KeyboardEvent.h

Issue 20986003: Define DOM_KEY_LOCATION_* constants on KeyboardEvent (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fix nits Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/fast/events/script-tests/keydown-numpad-keys.js ('k') | Source/core/dom/KeyboardEvent.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/dom/KeyboardEvent.h
diff --git a/Source/core/dom/KeyboardEvent.h b/Source/core/dom/KeyboardEvent.h
index 02c7e34e7770d5e5aecfd08ed26e587498f484a7..a22bc145d05f119acd28769f063ef05a3cdc1747 100644
--- a/Source/core/dom/KeyboardEvent.h
+++ b/Source/core/dom/KeyboardEvent.h
@@ -47,10 +47,13 @@ struct KeyboardEventInit : public UIEventInit {
class KeyboardEvent : public UIEventWithKeyState {
public:
enum KeyLocationCode {
- DOMKeyLocationStandard = 0x00,
- DOMKeyLocationLeft = 0x01,
- DOMKeyLocationRight = 0x02,
- DOMKeyLocationNumpad = 0x03
+ DOM_KEY_LOCATION_STANDARD = 0x00,
+ DOM_KEY_LOCATION_LEFT = 0x01,
+ DOM_KEY_LOCATION_RIGHT = 0x02,
+ DOM_KEY_LOCATION_NUMPAD = 0x03,
+ // FIXME: The following values are not supported yet (crbug.com/265446)
+ DOM_KEY_LOCATION_MOBILE = 0x04,
ojan 2013/07/29 22:09:07 I think we should pushback on the spec here. What
+ DOM_KEY_LOCATION_JOYSTICK = 0x05
ojan 2013/07/29 22:09:07 Same here. They gamepad API is for joysticks. Not
};
static PassRefPtr<KeyboardEvent> create()
« no previous file with comments | « LayoutTests/fast/events/script-tests/keydown-numpad-keys.js ('k') | Source/core/dom/KeyboardEvent.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698