Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 2098583002: SkMatrix44 clarifications and clean-ups (Closed)

Created:
4 years, 6 months ago by msarett
Modified:
4 years, 6 months ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

SkMatrix44 clarifications and clean-ups Fixed row/col major bug and added comments to the header. Made SkMatrix::I() thread safe using constexpr. Added a test set3x3RowMajorf(). BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2098583002 Committed: https://skia.googlesource.com/skia/+/c1a3e24918f99fc0b975111afb39dca38c50eb5c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -18 lines) Patch
M include/core/SkMatrix44.h View 6 chunks +22 lines, -10 lines 0 comments Download
M src/codec/SkPngCodec.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/core/SkColorSpace.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M src/core/SkMatrix44.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/ColorSpaceTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/Matrix44Test.cpp View 2 chunks +18 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 15 (8 generated)
msarett
I didn't do anything too exciting here, mostly because I think SkMatrix44 makes a good ...
4 years, 6 months ago (2016-06-23 18:17:50 UTC) #5
reed1
lgtm
4 years, 6 months ago (2016-06-23 18:37:29 UTC) #6
reed1
lgtm
4 years, 6 months ago (2016-06-23 18:37:29 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2098583002/20001
4 years, 6 months ago (2016-06-23 18:55:22 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-23 19:16:02 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2098583002/20001
4 years, 6 months ago (2016-06-23 19:41:32 UTC) #13
commit-bot: I haz the power
4 years, 6 months ago (2016-06-23 19:42:33 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://skia.googlesource.com/skia/+/c1a3e24918f99fc0b975111afb39dca38c50eb5c

Powered by Google App Engine
This is Rietveld 408576698