Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(442)

Issue 2098563003: Update deprecation message for MediaStream ended event. (Closed)

Created:
4 years, 6 months ago by Guido Urdaneta
Modified:
4 years, 6 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2743
Target Ref:
refs/pending/branch-heads/2743
Project:
chromium
Visibility:
Public.

Description

Update deprecation message for MediaStream ended event. Remove recommendation to switch to the inactive event, since that one has been removed from the spec as well. Also remove MeasureAs annotation from the onended attribute. Addition of listeners via the attribute are already counted in addEventListenerInternal. BUG=608795 Review-Url: https://codereview.chromium.org/2085973002 Cr-Commit-Position: refs/heads/master@{#401331} (cherry picked from commit b25c29a9208689679fb20ecfdd822c1f661da146) Committed: https://chromium.googlesource.com/chromium/src/+/cd2341e0e120181fc2c3d42b220a0126b318f1cf

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M third_party/WebKit/LayoutTests/fast/mediastream/MediaStream-onended-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/Deprecation.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/mediastream/MediaStream.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
Guido Urdaneta
4 years, 6 months ago (2016-06-24 09:11:44 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
cd2341e0e120181fc2c3d42b220a0126b318f1cf.

Powered by Google App Engine
This is Rietveld 408576698