Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 2085973002: Update deprecation message for MediaStream ended event. (Closed)

Created:
4 years, 6 months ago by Guido Urdaneta
Modified:
4 years, 6 months ago
Reviewers:
foolip
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update deprecation message for MediaStream ended event. Remove recommendation to switch to the inactive event, since that one has been removed from the spec as well. Also remove MeasureAs annotation from the onended attribute. Addition of listeners via the attribute are already counted in addEventListenerInternal. BUG=608795 Committed: https://crrev.com/b25c29a9208689679fb20ecfdd822c1f661da146 Cr-Commit-Position: refs/heads/master@{#401331}

Patch Set 1 #

Patch Set 2 : Remove redundant count #

Patch Set 3 : update MediaStream-onended-expected.txt #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M third_party/WebKit/LayoutTests/fast/mediastream/MediaStream-onended-expected.txt View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/Deprecation.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/mediastream/MediaStream.idl View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (6 generated)
Guido Urdaneta
4 years, 6 months ago (2016-06-22 15:53:45 UTC) #3
Guido Urdaneta
On 2016/06/22 15:53:45, Guido Urdaneta wrote: Hi, PTAL
4 years, 6 months ago (2016-06-22 15:54:04 UTC) #4
foolip
lgtm but LayoutTests/fast/mediastream/MediaStream-onended-expected.txt needs to be updated.
4 years, 6 months ago (2016-06-22 16:03:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2085973002/40001
4 years, 6 months ago (2016-06-22 16:16:58 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 6 months ago (2016-06-22 17:35:59 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-06-22 17:39:12 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/b25c29a9208689679fb20ecfdd822c1f661da146
Cr-Commit-Position: refs/heads/master@{#401331}

Powered by Google App Engine
This is Rietveld 408576698