Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1049)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2098523002: Fix some issues found by coverity scans on Node.js (Closed)

Created:
4 years, 6 months ago by ofrobots
Modified:
4 years, 6 months ago
Reviewers:
dgozman, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix some issues found by coverity scans on Node.js BUG= R=pfeldman@chromium.org, dgozman@chromium.org Committed: https://crrev.com/bdb1a680c245c40132f492ec7f0e5b4dcb48210f Cr-Commit-Position: refs/heads/master@{#401981}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -11 lines) Patch
M third_party/WebKit/Source/platform/inspector_protocol/Maybe.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/inspector_protocol/String16STL.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/inspector_protocol/String16STL.cpp View 1 chunk +2 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/platform/inspector_protocol/ValueConversions.h View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
dgozman
lgtm
4 years, 6 months ago (2016-06-24 19:03:53 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2098523002/1
4 years, 6 months ago (2016-06-24 20:26:05 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-24 21:42:22 UTC) #4
commit-bot: I haz the power
4 years, 6 months ago (2016-06-24 21:44:25 UTC) #6
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/bdb1a680c245c40132f492ec7f0e5b4dcb48210f
Cr-Commit-Position: refs/heads/master@{#401981}

Powered by Google App Engine
This is Rietveld 408576698