Fix some issues found by coverity scans on Node.js

third_party/WebKit/Source/platform/inspector_protocol/String16STL.cpp

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "platform/inspector_protocol/String16STL.h"
 
 #include "platform/inspector_protocol/Platform.h"
 
 #include <algorithm>
 #include <cctype>
@@ skipping 544 matching lines @@
     //    ascii characters, so we know this will be sufficient).
     //  * We could allocate a CStringBuffer with an appropriate size to
     //    have a good chance of being able to write the string into the
     //    buffer without reallocing (say, 1.5 x length).
     if (length > std::numeric_limits<unsigned>::max() / 3)
         return std::string();
     std::vector<char> bufferVector(length * 3);
     char* buffer = bufferVector.data();
     const UChar* characters = m_impl.data();
 
-    bool strict = false;
-    ConversionResult result = convertUTF16ToUTF8(&characters, characters + length, &buffer, buffer + bufferVector.size(), strict);
+    ConversionResult result = convertUTF16ToUTF8(&characters, characters + length, &buffer, buffer + bufferVector.size(), false);
     DCHECK(result != targetExhausted); // (length * 3) should be sufficient for any conversion
 
     // Only produced from strict conversion.
-    if (result == sourceIllegal) {
-        DCHECK(strict);
-        return std::string();
-    }
+    DCHECK(result != sourceIllegal);
 
     // Check for an unconverted high surrogate.
     if (result == sourceExhausted) {
-        if (strict)
-            return std::string();
         // This should be one unpaired high surrogate. Treat it the same
         // was as an unpaired high surrogate would have been handled in
         // the middle of a string with non-strict conversion - which is
         // to say, simply encode it to UTF-8.
         DCHECK((characters + 1) == (m_impl.data() + length));
         DCHECK((*characters >= 0xD800) && (*characters <= 0xDBFF));
         // There should be room left, since one UChar hasn't been
         // converted.
         DCHECK((buffer + 3) <= (buffer + bufferVector.size()));
         putUTF8Triple(buffer, *characters);
     }
 
     return std::string(bufferVector.data(), buffer - bufferVector.data());
 }
 
 String16 String16::stripWhiteSpace() const
 {
     wstring result(m_impl);
     trim(result);
     return result;
 }
 
 } // namespace protocol
 } // namespace blink