Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(513)

Unified Diff: content/browser/renderer_host/render_widget_host_view_base.h

Issue 2098353005: Implement RenderWidgetHostViewBase::ImeCancelComposition for all Views (Aura Only) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressing creis@'s comments Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host_view_base.h
diff --git a/content/browser/renderer_host/render_widget_host_view_base.h b/content/browser/renderer_host/render_widget_host_view_base.h
index e823d37e54a3c4690e6ea6ec70442e2fb2e12bc9..f6a25c17c6e18b7a5b83149f686ace8cda3fc7e5 100644
--- a/content/browser/renderer_host/render_widget_host_view_base.h
+++ b/content/browser/renderer_host/render_widget_host_view_base.h
@@ -257,6 +257,12 @@ class CONTENT_EXPORT RenderWidgetHostViewBase : public RenderWidgetHostView,
// on all platforms (https://crbug.com/578168).
virtual void TextInputStateChanged(const TextInputState& text_input_state);
+ // Cancel the ongoing composition of the input method attached to the view.
+ // TODO(ekaramad): This method will not stay virtual. It will be moved up top
+ // with the other non-virtual methods after IME is fixed on all platforms.
+ // (https://crbug.com/578168).
+ virtual void ImeCancelComposition();
+
//----------------------------------------------------------------------------
// The following static methods are implemented by each platform.
@@ -282,9 +288,6 @@ class CONTENT_EXPORT RenderWidgetHostViewBase : public RenderWidgetHostView,
// Indicates whether the page has finished loading.
virtual void SetIsLoading(bool is_loading) = 0;
- // Cancel the ongoing composition of the input method attached to the view.
- virtual void ImeCancelComposition() = 0;
-
// Notifies the View that the renderer has ceased to exist.
virtual void RenderProcessGone(base::TerminationStatus status,
int error_code) = 0;

Powered by Google App Engine
This is Rietveld 408576698