Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(437)

Side by Side Diff: content/browser/renderer_host/render_widget_host_view_base.h

Issue 2098353005: Implement RenderWidgetHostViewBase::ImeCancelComposition for all Views (Aura Only) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressing creis@'s comments Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_VIEW_BASE_H_ 5 #ifndef CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_VIEW_BASE_H_
6 #define CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_VIEW_BASE_H_ 6 #define CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_VIEW_BASE_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 #include <stdint.h> 9 #include <stdint.h>
10 10
(...skipping 239 matching lines...) Expand 10 before | Expand all | Expand 10 after
250 virtual void TransformPointToLocalCoordSpace(const gfx::Point& point, 250 virtual void TransformPointToLocalCoordSpace(const gfx::Point& point,
251 cc::SurfaceId original_surface, 251 cc::SurfaceId original_surface,
252 gfx::Point* transformed_point); 252 gfx::Point* transformed_point);
253 253
254 // Updates the state of the input method attached to the view. 254 // Updates the state of the input method attached to the view.
255 // TODO(ekaramad): This method will not stay virtual. It will be moved up top 255 // TODO(ekaramad): This method will not stay virtual. It will be moved up top
256 // with the other non-virtual methods after TextInputState tracking is fixed 256 // with the other non-virtual methods after TextInputState tracking is fixed
257 // on all platforms (https://crbug.com/578168). 257 // on all platforms (https://crbug.com/578168).
258 virtual void TextInputStateChanged(const TextInputState& text_input_state); 258 virtual void TextInputStateChanged(const TextInputState& text_input_state);
259 259
260 // Cancel the ongoing composition of the input method attached to the view.
261 // TODO(ekaramad): This method will not stay virtual. It will be moved up top
262 // with the other non-virtual methods after IME is fixed on all platforms.
263 // (https://crbug.com/578168).
264 virtual void ImeCancelComposition();
265
260 //---------------------------------------------------------------------------- 266 //----------------------------------------------------------------------------
261 // The following static methods are implemented by each platform. 267 // The following static methods are implemented by each platform.
262 268
263 static void GetDefaultScreenInfo(blink::WebScreenInfo* results); 269 static void GetDefaultScreenInfo(blink::WebScreenInfo* results);
264 270
265 //---------------------------------------------------------------------------- 271 //----------------------------------------------------------------------------
266 // The following pure virtual methods are implemented by derived classes. 272 // The following pure virtual methods are implemented by derived classes.
267 273
268 // Perform all the initialization steps necessary for this object to represent 274 // Perform all the initialization steps necessary for this object to represent
269 // a popup (such as a <select> dropdown), then shows the popup at |pos|. 275 // a popup (such as a <select> dropdown), then shows the popup at |pos|.
270 virtual void InitAsPopup(RenderWidgetHostView* parent_host_view, 276 virtual void InitAsPopup(RenderWidgetHostView* parent_host_view,
271 const gfx::Rect& bounds) = 0; 277 const gfx::Rect& bounds) = 0;
272 278
273 // Perform all the initialization steps necessary for this object to represent 279 // Perform all the initialization steps necessary for this object to represent
274 // a full screen window. 280 // a full screen window.
275 // |reference_host_view| is the view associated with the creating page that 281 // |reference_host_view| is the view associated with the creating page that
276 // helps to position the full screen widget on the correct monitor. 282 // helps to position the full screen widget on the correct monitor.
277 virtual void InitAsFullscreen(RenderWidgetHostView* reference_host_view) = 0; 283 virtual void InitAsFullscreen(RenderWidgetHostView* reference_host_view) = 0;
278 284
279 // Sets the cursor to the one associated with the specified cursor_type 285 // Sets the cursor to the one associated with the specified cursor_type
280 virtual void UpdateCursor(const WebCursor& cursor) = 0; 286 virtual void UpdateCursor(const WebCursor& cursor) = 0;
281 287
282 // Indicates whether the page has finished loading. 288 // Indicates whether the page has finished loading.
283 virtual void SetIsLoading(bool is_loading) = 0; 289 virtual void SetIsLoading(bool is_loading) = 0;
284 290
285 // Cancel the ongoing composition of the input method attached to the view.
286 virtual void ImeCancelComposition() = 0;
287
288 // Notifies the View that the renderer has ceased to exist. 291 // Notifies the View that the renderer has ceased to exist.
289 virtual void RenderProcessGone(base::TerminationStatus status, 292 virtual void RenderProcessGone(base::TerminationStatus status,
290 int error_code) = 0; 293 int error_code) = 0;
291 294
292 // Tells the View to destroy itself. 295 // Tells the View to destroy itself.
293 virtual void Destroy() = 0; 296 virtual void Destroy() = 0;
294 297
295 // Tells the View that the tooltip text for the current mouse position over 298 // Tells the View that the tooltip text for the current mouse position over
296 // the page has changed. 299 // the page has changed.
297 virtual void SetTooltipText(const base::string16& tooltip_text) = 0; 300 virtual void SetTooltipText(const base::string16& tooltip_text) = 0;
(...skipping 167 matching lines...) Expand 10 before | Expand all | Expand 10 after
465 base::ObserverList<RenderWidgetHostViewBaseObserver> observers_; 468 base::ObserverList<RenderWidgetHostViewBaseObserver> observers_;
466 469
467 base::WeakPtrFactory<RenderWidgetHostViewBase> weak_factory_; 470 base::WeakPtrFactory<RenderWidgetHostViewBase> weak_factory_;
468 471
469 DISALLOW_COPY_AND_ASSIGN(RenderWidgetHostViewBase); 472 DISALLOW_COPY_AND_ASSIGN(RenderWidgetHostViewBase);
470 }; 473 };
471 474
472 } // namespace content 475 } // namespace content
473 476
474 #endif // CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_VIEW_BASE_H_ 477 #endif // CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_VIEW_BASE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698