Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 2098243002: Remove unnecessary finalization of IDBObserver classes. (Closed)

Created:
4 years, 5 months ago by sof
Modified:
4 years, 5 months ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, blink-reviews, jsbell+idb_chromium.org, cmumford
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unnecessary finalization of IDBObserver classes. IDBObserver and IDBObserverChanges do not need to be finalized, nor have user-defined empty destructors. R= BUG=609934 Committed: https://crrev.com/eb03c7af065402fdfb997eea91bf7a7a650c94aa Cr-Commit-Position: refs/heads/master@{#402117}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -9 lines) Patch
M third_party/WebKit/Source/modules/indexeddb/IDBObserver.h View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/IDBObserver.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/IDBObserverChanges.h View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/IDBObserverChanges.cpp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
sof
please take a look.
4 years, 5 months ago (2016-06-26 19:27:09 UTC) #2
haraken
LGTM
4 years, 5 months ago (2016-06-27 01:07:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2098243002/1
4 years, 5 months ago (2016-06-27 05:06:08 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-27 05:10:12 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-06-27 05:12:12 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/eb03c7af065402fdfb997eea91bf7a7a650c94aa
Cr-Commit-Position: refs/heads/master@{#402117}

Powered by Google App Engine
This is Rietveld 408576698